qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] crypto: Fix typo in example
@ 2015-12-21 15:54 Eric Blake
  2015-12-21 16:12 ` Daniel P. Berrange
  2016-01-10 17:53 ` Michael Tokarev
  0 siblings, 2 replies; 3+ messages in thread
From: Eric Blake @ 2015-12-21 15:54 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-trivial

The example code wouldn't even compile, since it did not use
a consistent spelling for the Error ** parameter.

Signed-off-by: Eric Blake <eblake@redhat.com>
---
 include/crypto/tlssession.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/crypto/tlssession.h b/include/crypto/tlssession.h
index b38fe69..d356a8d 100644
--- a/include/crypto/tlssession.h
+++ b/include/crypto/tlssession.h
@@ -56,7 +56,7 @@
  *
  * static int mysock_run_tls(int sockfd,
  *                           QCryptoTLSCreds *creds,
- *                           Error *erp)
+ *                           Error *errp)
  * {
  *    QCryptoTLSSession *sess;
  *
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] crypto: Fix typo in example
  2015-12-21 15:54 [Qemu-devel] [PATCH] crypto: Fix typo in example Eric Blake
@ 2015-12-21 16:12 ` Daniel P. Berrange
  2016-01-10 17:53 ` Michael Tokarev
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel P. Berrange @ 2015-12-21 16:12 UTC (permalink / raw)
  To: Eric Blake; +Cc: qemu-trivial, qemu-devel

On Mon, Dec 21, 2015 at 08:54:17AM -0700, Eric Blake wrote:
> The example code wouldn't even compile, since it did not use
> a consistent spelling for the Error ** parameter.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

> ---
>  include/crypto/tlssession.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/crypto/tlssession.h b/include/crypto/tlssession.h
> index b38fe69..d356a8d 100644
> --- a/include/crypto/tlssession.h
> +++ b/include/crypto/tlssession.h
> @@ -56,7 +56,7 @@
>   *
>   * static int mysock_run_tls(int sockfd,
>   *                           QCryptoTLSCreds *creds,
> - *                           Error *erp)
> + *                           Error *errp)
>   * {
>   *    QCryptoTLSSession *sess;
>   *

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] crypto: Fix typo in example
  2015-12-21 15:54 [Qemu-devel] [PATCH] crypto: Fix typo in example Eric Blake
  2015-12-21 16:12 ` Daniel P. Berrange
@ 2016-01-10 17:53 ` Michael Tokarev
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2016-01-10 17:53 UTC (permalink / raw)
  To: Eric Blake, qemu-devel; +Cc: qemu-trivial

21.12.2015 18:54, Eric Blake wrote:
> The example code wouldn't even compile, since it did not use
> a consistent spelling for the Error ** parameter.


Applied to -trivial, thanks!

/mjt

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-01-10 17:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-21 15:54 [Qemu-devel] [PATCH] crypto: Fix typo in example Eric Blake
2015-12-21 16:12 ` Daniel P. Berrange
2016-01-10 17:53 ` Michael Tokarev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).