From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBK9I-0002eG-18 for qemu-devel@nongnu.org; Tue, 22 Dec 2015 05:26:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBK9E-0001uO-NW for qemu-devel@nongnu.org; Tue, 22 Dec 2015 05:26:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBK9E-0001uH-Fn for qemu-devel@nongnu.org; Tue, 22 Dec 2015 05:26:28 -0500 Date: Tue, 22 Dec 2015 10:26:22 +0000 From: "Daniel P. Berrange" Message-ID: <20151222102622.GC10082@redhat.com> References: <1450777749-14022-1-git-send-email-den@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1450777749-14022-1-git-send-email-den@openvz.org> Subject: Re: [Qemu-devel] [PATCH v2 1/1] doc: document chardev option 'append' Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Paolo Bonzini , Dmitry Mishin , qemu-devel@nongnu.org, Markus Armbruster On Tue, Dec 22, 2015 at 12:49:09PM +0300, Denis V. Lunev wrote: > commit 31e38a22a0c5a25646f966f001e1f5513d5a186d > Author: Olga Krishtal > Date: Fri Dec 4 09:42:04 2015 +0300 > > qemu-char: append opt to stop truncation of serial file > > has added the option to the runtime but does not added it to -help > output. This blocks libvirt from using it. You can remove this sentance about libvirt - we stopped parsing -help output a long time ago. We exclusively use QMP now. > > Signed-off-by: Denis V. Lunev > CC: Dmitry Mishin > CC: Eric Blake > CC: Markus Armbruster > CC: Paolo Bonzini > --- > Changes from v1: > - fixed default value to 'off' > > qemu-options.hx | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 49afe6c..f706e4a 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -2044,7 +2044,7 @@ DEF("chardev", HAS_ARG, QEMU_OPTION_chardev, > "-chardev vc,id=id[[,width=width][,height=height]][[,cols=cols][,rows=rows]]\n" > " [,mux=on|off]\n" > "-chardev ringbuf,id=id[,size=size]\n" > - "-chardev file,id=id,path=path[,mux=on|off]\n" > + "-chardev file,id=id,path=path[,mux=on|off][,append=on|off]\n" > "-chardev pipe,id=id,path=path[,mux=on|off]\n" > #ifdef _WIN32 > "-chardev console,id=id[,mux=on|off]\n" > @@ -2199,7 +2199,7 @@ console with the given dimensions. > Create a ring buffer with fixed size @option{size}. > @var{size} must be a power of two, and defaults to @code{64K}). > > -@item -chardev file ,id=@var{id} ,path=@var{path} > +@item -chardev file ,id=@var{id} ,path=@var{path} [,append=@var{on|off}] > > Log all traffic received from the guest to a file. > > @@ -2207,6 +2207,9 @@ Log all traffic received from the guest to a file. > created if it does not already exist, and overwritten if it does. @option{path} > is required. > > +@option{append} specifies that QEMU must truncate the file on open. > +@option{append} is optional, default value is off. > + > @item -chardev pipe ,id=@var{id} ,path=@var{path} > > Create a two-way connection to the guest. The behaviour differs slightly between Assuming the commit msg is tweaked to remove mention of libvirt, then: Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|