From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38667)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1aBPFP-0007HC-NZ
	for qemu-devel@nongnu.org; Tue, 22 Dec 2015 10:53:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1aBPFJ-0007e8-JB
	for qemu-devel@nongnu.org; Tue, 22 Dec 2015 10:53:08 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43762)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1aBPFJ-0007e1-DI
	for qemu-devel@nongnu.org; Tue, 22 Dec 2015 10:53:05 -0500
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (Postfix) with ESMTPS id E93BEC0B7E1E
	for <qemu-devel@nongnu.org>; Tue, 22 Dec 2015 15:53:04 +0000 (UTC)
Date: Tue, 22 Dec 2015 15:53:01 +0000
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20151222155301.GH10082@redhat.com>
References: <1450714014-16849-1-git-send-email-berrange@redhat.com>
	<1450714014-16849-6-git-send-email-berrange@redhat.com>
	<567829AA.1000508@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <567829AA.1000508@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 5/6] crypto: ensure qapi/crypto.json is
 listed in qapi-modules
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

On Mon, Dec 21, 2015 at 09:32:42AM -0700, Eric Blake wrote:
> On 12/21/2015 09:06 AM, Daniel P. Berrange wrote:
> > The rebuild of qapi-types.c/h is not correctly triggered
> > when qapi/crypto.json is changed because it was missing
> > from the list of files in the qapi-modules variable.
> > 
> > Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> > ---
> >  Makefile | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> > 
> > diff --git a/Makefile b/Makefile
> > index af3e5f1..82b2fc8 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -271,7 +271,8 @@ $(SRC_PATH)/qga/qapi-schema.json $(SRC_PATH)/scripts/qapi-commands.py $(qapi-py)
> >  
> >  qapi-modules = $(SRC_PATH)/qapi-schema.json $(SRC_PATH)/qapi/common.json \
> >                 $(SRC_PATH)/qapi/block.json $(SRC_PATH)/qapi/block-core.json \
> > -               $(SRC_PATH)/qapi/event.json $(SRC_PATH)/qapi/introspect.json
> > +               $(SRC_PATH)/qapi/event.json $(SRC_PATH)/qapi/introspect.json \
> > +               $(SRC_PATH)/qapi/crypto.json
> 
> Wonder if a wildcard for qapi/*.json would be any smarter.

I'm not sure if there's an official position, but it seems we mostly
avoid using wildcards in the QEMU Makefiles, so I figured to stick
with current practice.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|