qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Roman Kagan <rkagan@virtuozzo.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	qemu-devel@nongnu.org, qemu-stable@nongnu.org,
	Paolo Bonzini <pbonzini@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	"Denis V. Lunev" <den@openvz.org>, John Snow <jsnow@redhat.com>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes
Date: Tue, 22 Dec 2015 18:41:47 +0200	[thread overview]
Message-ID: <20151222164147.GA30352@redhat.com> (raw)
In-Reply-To: <1450467150-16227-3-git-send-email-rkagan@virtuozzo.com>

On Fri, Dec 18, 2015 at 10:32:30PM +0300, Roman Kagan wrote:
> Update the expected SSDTs to reflect the changes introduced in the
> previous patch.
> 
> Signed-off-by: Roman Kagan <rkagan@virtuozzo.com>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Michael S. Tsirkin <mst@redhat.com>
> CC: Igor Mammedov <imammedo@redhat.com>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Richard Henderson <rth@twiddle.net>
> CC: Eduardo Habkost <ehabkost@redhat.com>
> CC: John Snow <jsnow@redhat.com>
> CC: Kevin Wolf <kwolf@redhat.com>

Something strange is going on here.
If I apply your patch and this one on top, I get
a diff in SSDT.
Please review it manually and repost.

> ---
> changes since v2:
>  - new patch
> 
>  tests/acpi-test-data/pc/SSDT         | Bin 2486 -> 2588 bytes
>  tests/acpi-test-data/pc/SSDT.bridge  | Bin 4345 -> 4447 bytes
>  tests/acpi-test-data/q35/SSDT        | Bin 691 -> 872 bytes
>  tests/acpi-test-data/q35/SSDT.bridge | Bin 708 -> 889 bytes
>  4 files changed, 0 insertions(+), 0 deletions(-)
> 
> diff --git a/tests/acpi-test-data/pc/SSDT b/tests/acpi-test-data/pc/SSDT
> index 210d6a71e58aa34ce8e94121d25bcf58c3bd503c..ba3fa272b8235bdea28eadb0eaa3751f1ef4f59a 100644
> GIT binary patch
> delta 123
> zcmdlcJV%5pIM^jbhKqrLQFJ3$G-Hx0TZ}$Se6Uk|fU~E8XRu?un~SqSbd#Z*Pk<vw
> zyrWAH0|!vZQ%FI8fs2L9pG%05YdseemnskoaY=Li=gQ&w#>LOY0aE2ED9$Cq$bbr%
> KHYYNMasU8QB^ERQ
> 
> delta 24
> gcmbOuvQ3yPIM^j*8z%z;<MoYP(Ttl<GX`=109-!@NB{r;
> 
> diff --git a/tests/acpi-test-data/pc/SSDT.bridge b/tests/acpi-test-data/pc/SSDT.bridge
> index 6e6660b1fbe0bdb7fe0b257cb53c31fa9bb21a14..7350d36cf5c41c9d298d2dca6a893d579897c2c4 100644
> GIT binary patch
> delta 123
> zcmeyVcwdPtIM^j5UXX!-F>WJQG-Hx0TZ}$Se6Uk|fU~E8XRu?un~SqSbd#Z*Pk<vw
> zyrWAH0|!vZQ%FI8fs2L9pG%05YdseemnskoaY=Li=gQ&w#>LOY0aE2ED9$Cq$bbr%
> KHYYO9;0FNT%ono&
> 
> delta 24
> gcmcbw^iz>5IM^lRrvL*3qryh6XvWQ_8K>|A0BC0i#{d8T
> 
> diff --git a/tests/acpi-test-data/q35/SSDT b/tests/acpi-test-data/q35/SSDT
> index 0970c67ddb1456707c0111f7e5e659ef385af408..7d12c6a562c6a7d14099d4819ab469797548549d 100644
> GIT binary patch
> delta 203
> zcmdnY`htxsIM^j5gPDPWaoI*Le#Uwi?ihWR_+Y2_0B27F&tS)RHy3Av=q7tNp8!XW
> zct@8Y1`eQ*r;wfi0~ZV5e<)ypv$)oCF>$E^u@ILu*MF`Yu5VoYTpSPsoWKS!!VF-<
> gVt~>A|JY3cX>t`5=MrIL0J;^3VSs6~DC0av01bIR_5c6?
> 
> delta 24
> gcmaFCwwaYHIM^j*GZO;?W9>#Re#Xt`7-um809z#o3IG5A
> 
> diff --git a/tests/acpi-test-data/q35/SSDT.bridge b/tests/acpi-test-data/q35/SSDT.bridge
> index a77868861754ce0b3333b2b7bc8091c03a53754d..f5c4b44b5c0f8a049f321c5aadcc825c261ba99f 100644
> GIT binary patch
> delta 203
> zcmX@Y`jd?-IM^kml9_>l(QP9aKV!WMcZ@zue6Uk|fU~E8XRu?un~SqSbd$ZCPk<vw
> zyrWAH0|!vZQ%FyMfs2LjKNK*)SzPP6n7CAdScprS>pxcx*EcSHE)IwRPGAEVVFoZ_
> gF~I2mf9xiJG`R|jbBQoA0No12Fu=4~lyN;H0PbQx+5i9m
> 
> delta 24
> gcmey#c7&BHIM^lR2onPXqwGd5e#Xt`7*{g_09%v>?f?J)
> 
> -- 
> 2.5.0

  reply	other threads:[~2015-12-22 16:41 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16  7:45 [Qemu-devel] [PATCH v2 1/1] i386: expose floppy-related objects in SSDT Denis V. Lunev
2015-12-16 16:46 ` John Snow
2015-12-16 16:46 ` Igor Mammedov
2015-12-16 17:34   ` Roman Kagan
2015-12-16 22:15     ` Igor Mammedov
2015-12-17 13:26       ` Roman Kagan
2015-12-17 17:08         ` Igor Mammedov
2015-12-18 19:32 ` [Qemu-devel] [PATCH v3 0/2] " Roman Kagan
2015-12-18 19:32   ` [Qemu-devel] [PATCH v3 1/2] " Roman Kagan
2015-12-22 15:07     ` Michael S. Tsirkin
2015-12-22 15:13       ` Roman Kagan
2015-12-22 15:56     ` Igor Mammedov
2015-12-18 19:32   ` [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes Roman Kagan
2015-12-22 16:41     ` Michael S. Tsirkin [this message]
2015-12-23 13:08       ` Roman Kagan
2015-12-23 13:45         ` Michael S. Tsirkin
2015-12-23 15:06           ` Roman Kagan
2015-12-23 17:20             ` Roman Kagan
2015-12-23 17:47               ` Igor Mammedov
2015-12-23 17:51                 ` Roman Kagan
2015-12-24  6:17                   ` Michael S. Tsirkin
2015-12-25 15:25                     ` Roman Kagan
  -- strict thread matches above, loose matches on Subject: below --
2015-12-25 15:04 [Qemu-devel] [PATCH v4 0/4] i386: expose floppy-related objects in SSDT Roman Kagan
2015-12-25 15:04 ` [Qemu-devel] [PATCH v4 1/4] i386/pc: expose identifying the floppy controller Roman Kagan
2015-12-25 15:04 ` [Qemu-devel] [PATCH v4 2/4] i386/acpi: make floppy controller object dynamic Roman Kagan
2015-12-25 15:04 ` [Qemu-devel] [PATCH v4 3/4] expose floppy drive geometry and CMOS type Roman Kagan
2015-12-25 15:04 ` [Qemu-devel] [PATCH v4 4/4] i386: populate floppy drive information in SSDT Roman Kagan
2015-12-29 14:09 ` [Qemu-devel] [PATCH v4 0/4] i386: expose floppy-related objects " Igor Mammedov
2015-12-29 16:17   ` Roman Kagan
2015-12-29 16:27     ` Igor Mammedov
2015-12-29 16:42     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151222164147.GA30352@redhat.com \
    --to=mst@redhat.com \
    --cc=den@openvz.org \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=rkagan@virtuozzo.com \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).