From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59636) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBOrp-0007LG-Bi for qemu-devel@nongnu.org; Tue, 22 Dec 2015 10:28:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBOrl-00014E-W6 for qemu-devel@nongnu.org; Tue, 22 Dec 2015 10:28:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58016) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBOrl-00014A-Qo for qemu-devel@nongnu.org; Tue, 22 Dec 2015 10:28:45 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id C982D8F2F5 for ; Tue, 22 Dec 2015 15:28:44 +0000 (UTC) Date: Tue, 22 Dec 2015 17:28:42 +0200 From: "Michael S. Tsirkin" Message-ID: <20151222172647-mutt-send-email-mst@redhat.com> References: <1449704528-289297-1-git-send-email-imammedo@redhat.com> <1449704528-289297-2-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449704528-289297-2-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH 01/74] tests: acpi: print ASL diff in verbose mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org On Thu, Dec 10, 2015 at 12:40:55AM +0100, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > tests/bios-tables-test.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c > index 6d37332..50678b5 100644 > --- a/tests/bios-tables-test.c > +++ b/tests/bios-tables-test.c > @@ -580,6 +580,13 @@ static void test_acpi_asl(test_data *data) > (gchar *)&signature, > sdt->asl_file, sdt->aml_file, > exp_sdt->asl_file, exp_sdt->aml_file); > + if (getenv("V")) { How do you test? make check V=1? > + int ret G_GNUC_UNUSED; > + char *diff = g_strdup_printf("git diff --exit-code %s %s", > + exp_sdt->asl_file, sdt->asl_file); This assumes running under git which is generally wrong e.g. people build from tarballs. git is also not a build dependency. > + ret = system(diff) ; > + g_free(diff); > + } > } > } > g_string_free(asl, true); > -- > 1.8.3.1 >