From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57502)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shmulik.ladkani@ravellosystems.com>)
	id 1aBTkc-0006B3-1R
	for qemu-devel@nongnu.org; Tue, 22 Dec 2015 15:41:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <shmulik.ladkani@ravellosystems.com>)
	id 1aBTkY-00042J-RC
	for qemu-devel@nongnu.org; Tue, 22 Dec 2015 15:41:41 -0500
Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:35884)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shmulik.ladkani@ravellosystems.com>)
	id 1aBTkY-000421-Hg
	for qemu-devel@nongnu.org; Tue, 22 Dec 2015 15:41:38 -0500
Received: by mail-wm0-x234.google.com with SMTP id p187so123431037wmp.1
	for <qemu-devel@nongnu.org>; Tue, 22 Dec 2015 12:41:38 -0800 (PST)
Date: Tue, 22 Dec 2015 22:41:34 +0200
From: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
Message-ID: <20151222224134.3acde5f8@halley>
In-Reply-To: <1450765104-26135-2-git-send-email-yanmiaobest@gmail.com>
References: <1450765104-26135-1-git-send-email-yanmiaobest@gmail.com>
	<1450765104-26135-2-git-send-email-yanmiaobest@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/4] net/vmxnet3: return 1 on device
 activation failure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Miao Yan <yanmiaobest@gmail.com>
Cc: dmitry@daynix.com, jasowang@redhat.com, qemu-devel@nongnu.org

Hi,

On Mon, 21 Dec 2015 22:18:21 -0800 Miao Yan <yanmiaobest@gmail.com> wrote:
> When reading device status, 0 means device is successfully
> activated and 1 means error.
> 
> This behavior can be observed by the following steps:
> 
> 1) run a Linux distro on esxi server
> 2) modify vmxnet3 Linux driver to give it an invalid
>    address to 'adapter->shared_pa' which is the
>    shared memory for guest/host communication
> 
> This will trigger device activation failure and kernel
> log will have the following message:
> 
>    [ 7138.403256] vmxnet3 0000:03:00.0 eth1: Failed to activate dev: error 1

Could it be that various other error codes might be returned from ESXi
for a VMXNET3_CMD_ACTIVATE_DEV read, depending on device condition?

Regards,
Shmulik