From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBUFT-0000xf-Ru for qemu-devel@nongnu.org; Tue, 22 Dec 2015 16:13:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBUFQ-0002SD-ME for qemu-devel@nongnu.org; Tue, 22 Dec 2015 16:13:35 -0500 Received: from mail-wm0-x233.google.com ([2a00:1450:400c:c09::233]:34263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBUFQ-0002S2-B8 for qemu-devel@nongnu.org; Tue, 22 Dec 2015 16:13:32 -0500 Received: by mail-wm0-x233.google.com with SMTP id l126so124228403wml.1 for ; Tue, 22 Dec 2015 13:13:32 -0800 (PST) Date: Tue, 22 Dec 2015 23:13:29 +0200 From: Shmulik Ladkani Message-ID: <20151222231329.0832efd0@halley> In-Reply-To: <20151222224134.3acde5f8@halley> References: <1450765104-26135-1-git-send-email-yanmiaobest@gmail.com> <1450765104-26135-2-git-send-email-yanmiaobest@gmail.com> <20151222224134.3acde5f8@halley> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/4] net/vmxnet3: return 1 on device activation failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Miao Yan Cc: dmitry@daynix.com, jasowang@redhat.com, qemu-devel@nongnu.org On Tue, 22 Dec 2015 22:41:34 +0200 Shmulik Ladkani wrote: > Could it be that various other error codes might be returned from ESXi > for a VMXNET3_CMD_ACTIVATE_DEV read, depending on device condition? Thinking this over, the commit takes us one step into a finer device implementation, and we can always fine-tune it in the future. Reviewed-by: Shmulik Ladkani