From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBdd7-0004xQ-BU for qemu-devel@nongnu.org; Wed, 23 Dec 2015 02:14:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBdd2-0006oK-Bc for qemu-devel@nongnu.org; Wed, 23 Dec 2015 02:14:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBdd2-0006oD-6G for qemu-devel@nongnu.org; Wed, 23 Dec 2015 02:14:32 -0500 Date: Wed, 23 Dec 2015 15:14:26 +0800 From: Fam Zheng Message-ID: <20151223071426.GE14423@ad.usersys.redhat.com> References: <1450744268-25052-1-git-send-email-eblake@redhat.com> <1450744268-25052-3-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450744268-25052-3-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 02/14] qapi: Improve use of qmp/types.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Michael Roth , "Michael S. Tsirkin" , armbru@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino , pbonzini@redhat.com On Mon, 12/21 17:30, Eric Blake wrote: > 'qobject-json.h' is not a QObject subtype; include this file > directly in .c files that are using it, rather than abusing > qmp/types.h for that purpose. > > Meanwhile, for files that include a list of individual QObject > subtypes, it's easier to just use qmp/types.h for that purpose. > > Signed-off-by: Eric Blake Reviewed-by: Fam Zheng