From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBeTP-0000R9-Jo for qemu-devel@nongnu.org; Wed, 23 Dec 2015 03:08:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBeTJ-0005DP-TY for qemu-devel@nongnu.org; Wed, 23 Dec 2015 03:08:39 -0500 Received: from mail-pf0-x22e.google.com ([2607:f8b0:400e:c00::22e]:33371) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBeTJ-0005DF-O4 for qemu-devel@nongnu.org; Wed, 23 Dec 2015 03:08:33 -0500 Received: by mail-pf0-x22e.google.com with SMTP id q63so13195119pfb.0 for ; Wed, 23 Dec 2015 00:08:33 -0800 (PST) Date: Wed, 23 Dec 2015 16:08:30 +0800 From: Stefan Hajnoczi Message-ID: <20151223080830.GF5149@stefanha-x1.localdomain> References: <1450767586-28794-1-git-send-email-den@openvz.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ExXT7PjY8AI4Hyfa" Content-Disposition: inline In-Reply-To: <1450767586-28794-1-git-send-email-den@openvz.org> Subject: Re: [Qemu-devel] [PATCH 1/1] block: fix inability to start VM with native AIO List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Kevin Wolf , qemu-devel@nongnu.org --ExXT7PjY8AI4Hyfa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 22, 2015 at 09:59:46AM +0300, Denis V. Lunev wrote: > error: Failed to start domain rhel7 > error: internal error: process exited while connecting to monitor: > 2015-12-22T06:55:18.812637Z qemu-system-x86_64: > -drive file=3D/var/lib/libvirt/images/rhel7.qcow2,if=3Dnone, > id=3Ddrive-scsi0-0-0-0,format=3Dqcow2,cache=3Dnone,aio=3Dnative: > aio=3Dnative was specified, but it requires cache.direct=3Don, > which was not specified. >=20 > cache=3Dnone option was specified as seen above while the VM is unable to > start. The patch properly passed BDRV_O_NOCACHE to underlying layer. >=20 > The problem is revealed with > commit d657c0c289e944fc22289f5c318f48da87d79dcb > Author: Kevin Wolf > Date: Tue Dec 15 11:35:36 2015 +0100 >=20 > raw-posix: Make aio=3Dnative option binding >=20 > Signed-off-by: Denis V. Lunev > CC: Kevin Wolf > --- > block.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/block.c b/block.c > index 411edbf..fe0fbbc 100644 > --- a/block.c > +++ b/block.c > @@ -990,6 +990,7 @@ static int bdrv_open_common(BlockDriverState *bs, Bdr= vChild *file, > bs->opaque =3D g_malloc0(drv->instance_size); > =20 > /* Apply cache mode options */ > + update_flags_from_options(&open_flags, opts); > update_flags_from_options(&bs->open_flags, opts); > bdrv_set_enable_write_cache(bs, bs->open_flags & BDRV_O_CACHE_WB); By the way, my questions do not prevent your patch from being merged. I just wanted to raise them for Kevin because I'm concerned there are more bugs in this area. --ExXT7PjY8AI4Hyfa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWelZ+AAoJEJykq7OBq3PIE+AH+gNp1JgVFXY0Io1T9Qoipwnh SPRjCTQgyqGdqYNXigQgIlH1Z53uCLTffVl/NXIqlbUMCuFsfYjWsfss65kHiVCG +y+4C1Z52Fll2qYlkiVLBxG+giCzvZ1zVEuFG67uFLo7DftAqqOpSBKLd/kf1MsK xs68gyQEVXl4tUjMAT/KNJ2A8IWBjI/QrGVxBujmLqjky2gCU9i15m/NPF7l1mVW 1137As1wPj8HKYHTIHgPT4SB6fV/U+mwRraXrfxZtVsouQDi9qITyLfBWSR119W9 VHUgaExx8MH2DH8TjuecL48mH+Fcj7PhmTmOX7cqMDEHAbNcn5d/rkHYMf8USKM= =hHg6 -----END PGP SIGNATURE----- --ExXT7PjY8AI4Hyfa--