From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBh1l-0004nS-DF for qemu-devel@nongnu.org; Wed, 23 Dec 2015 05:52:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBh1h-0000lW-MR for qemu-devel@nongnu.org; Wed, 23 Dec 2015 05:52:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37199) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBh1h-0000lS-GM for qemu-devel@nongnu.org; Wed, 23 Dec 2015 05:52:13 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 1C156C062C96 for ; Wed, 23 Dec 2015 10:52:13 +0000 (UTC) Date: Wed, 23 Dec 2015 10:52:09 +0000 From: "Daniel P. Berrange" Message-ID: <20151223105209.GE20028@redhat.com> References: <1450714014-16849-1-git-send-email-berrange@redhat.com> <1450714014-16849-2-git-send-email-berrange@redhat.com> <56782662.9000502@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <56782662.9000502@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/6] crypto: add ability to query the cipher key, block & IV lens Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Markus Armbruster On Mon, Dec 21, 2015 at 09:18:42AM -0700, Eric Blake wrote: > On 12/21/2015 09:06 AM, Daniel P. Berrange wrote: > > Adds new methods to allow querying the length of the cipher > > key, block size and initialization vectors. > > In the subject line, I read 'lens' as a synonym for 'viewports', not > 'lengths'. But I don't know if avoiding the abbreviation is worth it, > because the subject line is already bordering on long. Maybe avoiding > it altogether is easier? > > crypto: Add additional query accessors Yes, I'll simplify this to "crypto: add additional query accessors for cipher instances" > > > > > Signed-off-by: Daniel P. Berrange > > --- > > crypto/cipher.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++ > > include/crypto/cipher.h | 37 +++++++++++++++++++++++++++++++++++ > > tests/test-crypto-cipher.c | 10 ++++++++++ > > 3 files changed, 95 insertions(+) > > > > But no problems with the actual patch, so: > Reviewed-by: Eric Blake Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|