From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50065)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1aBjWz-0002fI-K7
	for qemu-devel@nongnu.org; Wed, 23 Dec 2015 08:32:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1aBjWv-000463-KS
	for qemu-devel@nongnu.org; Wed, 23 Dec 2015 08:32:41 -0500
Received: from mx1.redhat.com ([209.132.183.28]:60539)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1aBjWv-00045s-FP
	for qemu-devel@nongnu.org; Wed, 23 Dec 2015 08:32:37 -0500
Date: Wed, 23 Dec 2015 14:32:34 +0100
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20151223143234.5678e9e3@nial.brq.redhat.com>
In-Reply-To: <1450856601-4944-4-git-send-email-lizhijian@cn.fujitsu.com>
References: <1450856601-4944-1-git-send-email-lizhijian@cn.fujitsu.com>
	<1450856601-4944-4-git-send-email-lizhijian@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/4] backends/hostmem-file: fix
 fb->mem_path leak
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Li Zhijian <lizhijian@cn.fujitsu.com>
Cc: qemu-devel@nongnu.org

On Wed, 23 Dec 2015 15:43:20 +0800
Li Zhijian <lizhijian@cn.fujitsu.com> wrote:

> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> ---
>  backends/hostmem-file.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c
> index e9b6d21..5a73fd0 100644
> --- a/backends/hostmem-file.c
> +++ b/backends/hostmem-file.c
> @@ -116,11 +116,19 @@ file_backend_instance_init(Object *o)
>                              set_mem_path, NULL);
>  }
>  
> +static void file_backend_instance_finalize(Object *o)
> +{
> +    HostMemoryBackendFile *fb = MEMORY_BACKEND_FILE(o);
> +
> +    g_free(fb->mem_path);
> +}
> +
>  static const TypeInfo file_backend_info = {
>      .name = TYPE_MEMORY_BACKEND_FILE,
>      .parent = TYPE_MEMORY_BACKEND,
>      .class_init = file_backend_class_init,
>      .instance_init = file_backend_instance_init,
> +    .instance_finalize = file_backend_instance_finalize,
>      .instance_size = sizeof(HostMemoryBackendFile),
>  };
>  

Reviewed-by: Igor Mammedov <imammedo@redhat.com>