From: "Michael S. Tsirkin" <mst@redhat.com>
To: Roman Kagan <rkagan@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-stable@nongnu.org,
"Denis V. Lunev" <den@openvz.org>,
Igor Mammedov <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>,
John Snow <jsnow@redhat.com>, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes
Date: Wed, 23 Dec 2015 15:45:29 +0200 [thread overview]
Message-ID: <20151223154417-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <20151223130817.GQ11808@rkaganb.sw.ru>
On Wed, Dec 23, 2015 at 04:08:19PM +0300, Roman Kagan wrote:
> On Tue, Dec 22, 2015 at 06:41:47PM +0200, Michael S. Tsirkin wrote:
> > On Fri, Dec 18, 2015 at 10:32:30PM +0300, Roman Kagan wrote:
> > > Update the expected SSDTs to reflect the changes introduced in the
> > > previous patch.
> > >
> > > Signed-off-by: Roman Kagan <rkagan@virtuozzo.com>
> > > Signed-off-by: Denis V. Lunev <den@openvz.org>
> > > CC: Michael S. Tsirkin <mst@redhat.com>
> > > CC: Igor Mammedov <imammedo@redhat.com>
> > > CC: Paolo Bonzini <pbonzini@redhat.com>
> > > CC: Richard Henderson <rth@twiddle.net>
> > > CC: Eduardo Habkost <ehabkost@redhat.com>
> > > CC: John Snow <jsnow@redhat.com>
> > > CC: Kevin Wolf <kwolf@redhat.com>
> >
> > Something strange is going on here.
> > If I apply your patch and this one on top, I get
> > a diff in SSDT.
>
> Aren't you by chance applying it on top of other patches that may affect
> SSDT? I double-checked the series on top of
>
> commit 5dc42c186d63b7b338594fc071cf290805dcc5a5
> Merge: c595b21 7236975
> Author: Peter Maydell <peter.maydell@linaro.org>
> Date: Tue Dec 22 14:21:42 2015 +0000
>
> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging
>
>
> and it passes OK...
>
> Roman.
This is the actual vs expected diff with both patches applied.
--- /tmp/asl-MN299X.dsl 2015-12-23 15:41:29.369837861 +0200
+++ /tmp/asl-T0S99X.dsl 2015-12-23 15:41:29.373837813 +0200
@@ -5,20 +5,20 @@
*
* Disassembling to symbolic ASL+ operators
*
- * Disassembly of /tmp/aml-VVVAAY, Wed Dec 23 15:41:29 2015
+ * Disassembly of tests/acpi-test-data/pc/SSDT, Wed Dec 23 15:41:29 2015
*
* Original Table Header:
* Signature "SSDT"
- * Length 0x000009B6 (2486)
+ * Length 0x00000A1C (2588)
* Revision 0x01
- * Checksum 0xD7
+ * Checksum 0x15
* OEM ID "BOCHS "
* OEM Table ID "BXPCSSDT"
* OEM Revision 0x00000001 (1)
* Compiler ID "BXPC"
* Compiler Version 0x00000001 (1)
*/
-DefinitionBlock ("/tmp/aml-VVVAAY.aml", "SSDT", 1, "BOCHS ", "BXPCSSDT", 0x00000001)
+DefinitionBlock ("tests/acpi-test-data/pc/SSDT.aml", "SSDT", 1, "BOCHS ", "BXPCSSDT", 0x00000001)
{
External (_SB_.CPEJ, MethodObj) // 2 Arguments
@@ -26,6 +26,7 @@ DefinitionBlock ("/tmp/aml-VVVAAY.aml",
External (_SB_.CPST, MethodObj) // 1 Arguments
External (_SB_.PCI0, DeviceObj)
External (_SB_.PCI0.BNUM, FieldUnitObj)
+ External (_SB_.PCI0.ISA_.FDC0, DeviceObj)
External (_SB_.PCI0.MHPD, DeviceObj)
External (_SB_.PCI0.PCEJ, MethodObj) // 2 Arguments
External (_SB_.PCI0.PCID, FieldUnitObj)
@@ -135,6 +136,40 @@ DefinitionBlock ("/tmp/aml-VVVAAY.aml",
})
}
+ Scope (\_SB.PCI0.ISA.FDC0)
+ {
+ Device (FLPA)
+ {
+ Name (_ADR, Zero) // _ADR: Address
+ Name (_FDI, Package (0x10) // _FDI: Floppy Drive Information
+ {
+ Zero,
+ 0x04,
+ 0x4F,
+ 0x12,
+ One,
+ 0xAF,
+ 0x02,
+ 0x25,
+ 0x02,
+ 0x12,
+ 0x1B,
+ 0xFF,
+ 0x6C,
+ 0xF6,
+ 0x0F,
+ 0x08
+ })
+ }
+
+ Name (_FDE, Buffer (0x14) // _FDE: Floppy Disk Enumerate
+ {
+ /* 0000 */ 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* ........ */
+ /* 0008 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* ........ */
+ /* 0010 */ 0x02, 0x00, 0x00, 0x00 /* .... */
+ })
+ }
+
Scope (\_SB)
{
Device (PCI0.PRES)
--- /tmp/asl-NKR59X.dsl 2015-12-23 15:41:30.429825430 +0200
+++ /tmp/asl-3MT59X.dsl 2015-12-23 15:41:30.432825395 +0200
@@ -5,26 +5,27 @@
*
* Disassembling to symbolic ASL+ operators
*
- * Disassembly of /tmp/aml-H6V69X, Wed Dec 23 15:41:30 2015
+ * Disassembly of tests/acpi-test-data/q35/SSDT, Wed Dec 23 15:41:30 2015
*
* Original Table Header:
* Signature "SSDT"
- * Length 0x000002B3 (691)
+ * Length 0x00000368 (872)
* Revision 0x01
- * Checksum 0x7D
+ * Checksum 0xA6
* OEM ID "BOCHS "
* OEM Table ID "BXPCSSDT"
* OEM Revision 0x00000001 (1)
* Compiler ID "BXPC"
* Compiler Version 0x00000001 (1)
*/
-DefinitionBlock ("/tmp/aml-H6V69X.aml", "SSDT", 1, "BOCHS ", "BXPCSSDT", 0x00000001)
+DefinitionBlock ("tests/acpi-test-data/q35/SSDT.aml", "SSDT", 1, "BOCHS ", "BXPCSSDT", 0x00000001)
{
External (_SB_.CPEJ, MethodObj) // 2 Arguments
External (_SB_.CPMA, MethodObj) // 1 Arguments
External (_SB_.CPST, MethodObj) // 1 Arguments
External (_SB_.PCI0, DeviceObj)
+ External (_SB_.PCI0.ISA_.FDC0, DeviceObj)
External (_SB_.PCI0.MHPD, DeviceObj)
Scope (\_SB.PCI0)
@@ -115,6 +116,64 @@ DefinitionBlock ("/tmp/aml-H6V69X.aml",
})
}
+ Scope (\_SB.PCI0.ISA.FDC0)
+ {
+ Device (FLPA)
+ {
+ Name (_ADR, Zero) // _ADR: Address
+ Name (_FDI, Package (0x10) // _FDI: Floppy Drive Information
+ {
+ Zero,
+ 0x04,
+ 0xFFFFFFFFFFFFFFFF,
+ Zero,
+ 0xFFFFFFFFFFFFFFFF,
+ 0xAF,
+ 0x02,
+ 0x25,
+ 0x02,
+ 0x12,
+ 0x1B,
+ 0xFF,
+ 0x6C,
+ 0xF6,
+ 0x0F,
+ 0x08
+ })
+ }
+
+ Device (FLPB)
+ {
+ Name (_ADR, One) // _ADR: Address
+ Name (_FDI, Package (0x10) // _FDI: Floppy Drive Information
+ {
+ One,
+ 0x04,
+ 0xFFFFFFFFFFFFFFFF,
+ Zero,
+ 0xFFFFFFFFFFFFFFFF,
+ 0xAF,
+ 0x02,
+ 0x25,
+ 0x02,
+ 0x12,
+ 0x1B,
+ 0xFF,
+ 0x6C,
+ 0xF6,
+ 0x0F,
+ 0x08
+ })
+ }
+
+ Name (_FDE, Buffer (0x14) // _FDE: Floppy Disk Enumerate
+ {
+ /* 0000 */ 0x01, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, /* ........ */
+ /* 0008 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* ........ */
+ /* 0010 */ 0x02, 0x00, 0x00, 0x00 /* .... */
+ })
+ }
+
Scope (\_SB)
{
Device (PCI0.PRES)
next prev parent reply other threads:[~2015-12-23 13:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 7:45 [Qemu-devel] [PATCH v2 1/1] i386: expose floppy-related objects in SSDT Denis V. Lunev
2015-12-16 16:46 ` John Snow
2015-12-16 16:46 ` Igor Mammedov
2015-12-16 17:34 ` Roman Kagan
2015-12-16 22:15 ` Igor Mammedov
2015-12-17 13:26 ` Roman Kagan
2015-12-17 17:08 ` Igor Mammedov
2015-12-18 19:32 ` [Qemu-devel] [PATCH v3 0/2] " Roman Kagan
2015-12-18 19:32 ` [Qemu-devel] [PATCH v3 1/2] " Roman Kagan
2015-12-22 15:07 ` Michael S. Tsirkin
2015-12-22 15:13 ` Roman Kagan
2015-12-22 15:56 ` Igor Mammedov
2015-12-18 19:32 ` [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes Roman Kagan
2015-12-22 16:41 ` Michael S. Tsirkin
2015-12-23 13:08 ` Roman Kagan
2015-12-23 13:45 ` Michael S. Tsirkin [this message]
2015-12-23 15:06 ` Roman Kagan
2015-12-23 17:20 ` Roman Kagan
2015-12-23 17:47 ` Igor Mammedov
2015-12-23 17:51 ` Roman Kagan
2015-12-24 6:17 ` Michael S. Tsirkin
2015-12-25 15:25 ` Roman Kagan
-- strict thread matches above, loose matches on Subject: below --
2015-12-25 15:04 [Qemu-devel] [PATCH v4 0/4] i386: expose floppy-related objects in SSDT Roman Kagan
2015-12-25 15:04 ` [Qemu-devel] [PATCH v4 1/4] i386/pc: expose identifying the floppy controller Roman Kagan
2015-12-25 15:04 ` [Qemu-devel] [PATCH v4 2/4] i386/acpi: make floppy controller object dynamic Roman Kagan
2015-12-25 15:04 ` [Qemu-devel] [PATCH v4 3/4] expose floppy drive geometry and CMOS type Roman Kagan
2015-12-25 15:04 ` [Qemu-devel] [PATCH v4 4/4] i386: populate floppy drive information in SSDT Roman Kagan
2015-12-29 14:09 ` [Qemu-devel] [PATCH v4 0/4] i386: expose floppy-related objects " Igor Mammedov
2015-12-29 16:17 ` Roman Kagan
2015-12-29 16:27 ` Igor Mammedov
2015-12-29 16:42 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151223154417-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=den@openvz.org \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=rkagan@virtuozzo.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).