From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54957) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBjkx-0006wa-0a for qemu-devel@nongnu.org; Wed, 23 Dec 2015 08:47:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBjkt-0000Ow-Lz for qemu-devel@nongnu.org; Wed, 23 Dec 2015 08:47:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46455) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBjkt-0000Op-G3 for qemu-devel@nongnu.org; Wed, 23 Dec 2015 08:47:03 -0500 Date: Wed, 23 Dec 2015 15:47:00 +0200 From: "Michael S. Tsirkin" Message-ID: <20151223154626-mutt-send-email-mst@redhat.com> References: <20151217085213.10306.97858.stgit@bahia.huguette.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20151217085213.10306.97858.stgit@bahia.huguette.org> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 0/3] virtio: cross-endian helpers fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: Cornelia Huck , qemu-devel@nongnu.org On Thu, Dec 17, 2015 at 09:52:46AM +0100, Greg Kurz wrote: > This series tries to rework cross-endian helpers for better clarity. > It does not change behaviour, except perhaps patch 3/3 even if I could = not > measure any performance gain. Breaks build: CC mips64-softmmu/hw/mips/mips_malta.o /home/mst/scm/qemu/hw/net/vhost_net.c: In function =E2=80=98vhost_net_set_vnet_endian=E2=80=99: /home/mst/scm/qemu/hw/net/vhost_net.c:208:10: error: implicit declaration of function =E2=80=98virtio_legacy_is_cross_endian=E2=80=99 [-Werror=3Dimplicit-function-declaration] (virtio_legacy_is_cross_endian(dev) && !virtio_is_big_endian(dev))) { ^ /home/mst/scm/qemu/hw/net/vhost_net.c:208:9: error: nested extern declaration of =E2=80=98virtio_legacy_is_cross_endian=E2=80=99 [-Werror=3D= nested-externs] (virtio_legacy_is_cross_endian(dev) && !virtio_is_big_endian(dev))) { ^ cc1: all warnings being treated as errors /home/mst/scm/qemu/rules.mak:57: recipe for target 'hw/net/vhost_net.o' failed make[1]: *** [hw/net/vhost_net.o] Error 1 Makefile:186: recipe for target 'subdir-i386-softmmu' failed make: *** [subdir-i386-softmmu] Error 2 please always build all architectures. > --- >=20 > Greg Kurz (3): > virtio: move cross-endian helper to vhost > vhost: move virtio 1.0 check to cross-endian helper > virtio: optimize virtio_access_is_big_endian() for little-endian = targets >=20 >=20 > hw/virtio/vhost.c | 22 ++++++++++++++++++---- > include/hw/virtio/virtio-access.h | 16 +++------------- > 2 files changed, 21 insertions(+), 17 deletions(-)