From: Kevin O'Connor <kevin@koconnor.net>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: "Huangweidong (C)" <weidong.huang@huawei.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Radim Krcmar <rkrcmar@redhat.com>,
"seabios@seabios.org" <seabios@seabios.org>,
"Xulei (Stone)" <stone.xulei@huawei.com>,
qemu-devel <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform
Date: Wed, 23 Dec 2015 13:06:01 -0500 [thread overview]
Message-ID: <20151223180600.GA2700@morn.lan> (raw)
In-Reply-To: <33183CC9F5247A488A2544077AF19020B02B88A5@SZXEMA503-MBS.china.huawei.com>
On Wed, Dec 23, 2015 at 06:40:12AM +0000, Gonglei (Arei) wrote:
> > From: Kevin O'Connor [mailto:kevin@koconnor.net]
> > On Tue, Dec 22, 2015 at 02:14:12AM +0000, Gonglei (Arei) wrote:
> > > Sorry, it doesn't work. What's worse is we cannot stop SeaBIOS stuck by
> > > Setting "CONFIG_ENTRY_EXTRASTACK=n" after applying this patch.
> >
> > Oops, can you try with the patch below instead?
> >
>
> It works now. Thanks!
>
> But do we need to check other possible situations
> that maybe cause *extra stack* broken or overridden?
I believe the issue is that an NMI could occur while SeaBIOS is
already using its extra stack. The code is not prepared to switch
into the extra stack while already on the extra stack. SeaBIOS is
careful to always disable IRQs while running C code to prevent this
issue, but disabling normal IRQs does not disable NMIs. So, I believe
this issue is specific to the nature of NMIs.
-Kevin
next prev parent reply other threads:[~2015-12-23 18:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 6:58 [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform Xulei (Stone, Euler)
2015-11-04 0:48 ` Gonglei
2015-11-04 17:42 ` Kevin O'Connor
2015-11-06 9:12 ` Xulei (Stone)
2015-11-09 13:32 ` Kevin O'Connor
2015-11-09 20:06 ` Kevin O'Connor
2015-11-09 20:27 ` Kevin O'Connor
2015-11-19 1:04 ` Xulei (Stone)
2015-11-19 12:42 ` Xulei (Stone)
2015-11-19 13:40 ` Kevin O'Connor
2015-11-20 2:05 ` Xulei (Stone)
[not found] ` <33183CC9F5247A488A2544077AF19020B02B72BA@SZXEMA503-MBS.china.huawei.com>
2015-12-18 23:13 ` Kevin O'Connor
2015-12-19 6:28 ` Gonglei (Arei)
2015-12-19 12:03 ` Gonglei (Arei)
2015-12-19 15:11 ` Kevin O'Connor
2015-12-20 9:49 ` Gonglei (Arei)
2015-12-20 14:33 ` Kevin O'Connor
2015-12-21 9:41 ` Gonglei (Arei)
2015-12-21 18:47 ` Kevin O'Connor
2015-12-22 2:14 ` Gonglei (Arei)
2015-12-22 3:15 ` Xulei (Stone)
2015-12-22 15:38 ` Kevin O'Connor
2015-12-22 15:51 ` Kevin O'Connor
2015-12-23 6:40 ` Gonglei (Arei)
2015-12-23 18:06 ` Kevin O'Connor [this message]
2015-12-19 1:08 ` Gonglei (Arei)
-- strict thread matches above, loose matches on Subject: below --
2015-11-04 0:19 Xulei (Stone, Euler)
2015-11-03 6:29 Xulei (Stone, Euler)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151223180600.GA2700@morn.lan \
--to=kevin@koconnor.net \
--cc=arei.gonglei@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkrcmar@redhat.com \
--cc=seabios@seabios.org \
--cc=stone.xulei@huawei.com \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).