From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBp2q-0002Rc-Od for qemu-devel@nongnu.org; Wed, 23 Dec 2015 14:25:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBp2p-0003VZ-Pc for qemu-devel@nongnu.org; Wed, 23 Dec 2015 14:25:56 -0500 Date: Wed, 23 Dec 2015 19:25:46 +0000 From: "Daniel P. Berrange" Message-ID: <20151223192546.GU20028@redhat.com> References: <1450782389-17326-1-git-send-email-berrange@redhat.com> <1450782389-17326-5-git-send-email-berrange@redhat.com> <56798075.50005@redhat.com> <20151222172401.GL10082@redhat.com> <567AE199.5090605@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <567AE199.5090605@redhat.com> Subject: Re: [Qemu-devel] [PATCH 4/7] qemu-io: add support for --object command line arg Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Kevin Wolf , qemu-block@nongnu.org, qemu-devel@nongnu.org, Markus Armbruster , Andreas =?utf-8?Q?F=C3=A4rber?= On Wed, Dec 23, 2015 at 07:02:01PM +0100, Paolo Bonzini wrote: > > > On 22/12/2015 18:24, Daniel P. Berrange wrote: > > I was a little reluctant to move this 'object_create' method into the > > qom/ code though, since I hate the idea of the legacy 'QemuOpts' data > > anywhere near those nice new APIs. I guess I could perhaps just keep the > > qemu_opts_to_qdict() call in the caller. > > I disagree with calling QemuOpts legacy, but I agree that this shouldn't > be in qom/object_interfaces.c. However, it could be moved to a separate > file in qom/. Ok, yeah, I shouldn't have called it legacy really. This was my shorthand for saying that internal infrastructure APIs should strive to be qapi/qom based, and QemuOpts should only be used at the very top most level (ie cli ARGV) and converted to qapi/qom as soon as possible. I think that my v2 series achieves that goal fairly well. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|