From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBw3B-000695-5A for qemu-devel@nongnu.org; Wed, 23 Dec 2015 21:54:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBw3A-0002UD-B5 for qemu-devel@nongnu.org; Wed, 23 Dec 2015 21:54:45 -0500 Date: Thu, 24 Dec 2015 10:54:34 +0800 From: Fam Zheng Message-ID: <20151224025434.GA23372@ad.usersys.redhat.com> References: <1450843928-15380-1-git-send-email-famz@redhat.com> <1450843928-15380-2-git-send-email-famz@redhat.com> <567B391E.9080101@redhat.com> <567B3A76.2000602@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <567B3A76.2000602@redhat.com> Subject: Re: [Qemu-devel] [PATCH v7 1/2] mirror: Rewrite mirror_iteration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , pbonzini@redhat.com, Jeff Cody , qemu-devel@nongnu.org, qemu-block@nongnu.org On Thu, 12/24 01:21, Max Reitz wrote: > On 24.12.2015 01:15, Max Reitz wrote: > > On 23.12.2015 05:12, Fam Zheng wrote: > >> The "pnum < nb_sectors" condition in deciding whether to actually copy > >> data is unnecessarily strict, and the qiov initialization is > >> unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. > >> > >> Rewrite mirror_iteration to fix both flaws. > >> > >> Signed-off-by: Fam Zheng > >> --- > >> block/mirror.c | 308 +++++++++++++++++++++++++++++++++++---------------------- > >> 1 file changed, 188 insertions(+), 120 deletions(-) > > > > Reviewed-by: Max Reitz > > Forgot to note: I think this patch needs a rebase already. > Thanks for noticing that! I'm rebasing it now. Fam