From: "Michael S. Tsirkin" <mst@redhat.com>
To: Roman Kagan <rkagan@virtuozzo.com>,
Igor Mammedov <imammedo@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
"Denis V. Lunev" <den@openvz.org>,
qemu-stable@nongnu.org, qemu-devel@nongnu.org,
Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes
Date: Thu, 24 Dec 2015 08:17:45 +0200 [thread overview]
Message-ID: <20151224081532-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <20151223175143.GA2767@rkaganb.sw.ru>
On Wed, Dec 23, 2015 at 08:51:45PM +0300, Roman Kagan wrote:
> On Wed, Dec 23, 2015 at 06:47:16PM +0100, Igor Mammedov wrote:
> > On Wed, 23 Dec 2015 20:20:54 +0300
> > Roman Kagan <rkagan@virtuozzo.com> wrote:
> > > > ... two 1.44M drives with bogus geometry for q35.
> > >
> > > This one is a bug in my patch, indeed: I was tricked by FDRIVE_DRV_NONE
> > > being non-zero, and forgot to initialize the respective fields in
> > > acpi_get_misc_info() in case there is no floppy controller at all.
> > so instead of fake initialization, it's worth to make your patch
> > conditional on presence of controller after all.
> > i.e. add AML only if controller was present.
>
> Indeed :)
>
> Roman.
Or rather, start series with a patch making FDC conditional,
then update expected ssdt, then tweak methods within -
should not change ssdt since we don't create a floppy in
the test.
--
MST
next prev parent reply other threads:[~2015-12-24 6:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 7:45 [Qemu-devel] [PATCH v2 1/1] i386: expose floppy-related objects in SSDT Denis V. Lunev
2015-12-16 16:46 ` John Snow
2015-12-16 16:46 ` Igor Mammedov
2015-12-16 17:34 ` Roman Kagan
2015-12-16 22:15 ` Igor Mammedov
2015-12-17 13:26 ` Roman Kagan
2015-12-17 17:08 ` Igor Mammedov
2015-12-18 19:32 ` [Qemu-devel] [PATCH v3 0/2] " Roman Kagan
2015-12-18 19:32 ` [Qemu-devel] [PATCH v3 1/2] " Roman Kagan
2015-12-22 15:07 ` Michael S. Tsirkin
2015-12-22 15:13 ` Roman Kagan
2015-12-22 15:56 ` Igor Mammedov
2015-12-18 19:32 ` [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes Roman Kagan
2015-12-22 16:41 ` Michael S. Tsirkin
2015-12-23 13:08 ` Roman Kagan
2015-12-23 13:45 ` Michael S. Tsirkin
2015-12-23 15:06 ` Roman Kagan
2015-12-23 17:20 ` Roman Kagan
2015-12-23 17:47 ` Igor Mammedov
2015-12-23 17:51 ` Roman Kagan
2015-12-24 6:17 ` Michael S. Tsirkin [this message]
2015-12-25 15:25 ` Roman Kagan
-- strict thread matches above, loose matches on Subject: below --
2015-12-25 15:04 [Qemu-devel] [PATCH v4 0/4] i386: expose floppy-related objects in SSDT Roman Kagan
2015-12-25 15:04 ` [Qemu-devel] [PATCH v4 1/4] i386/pc: expose identifying the floppy controller Roman Kagan
2015-12-25 15:04 ` [Qemu-devel] [PATCH v4 2/4] i386/acpi: make floppy controller object dynamic Roman Kagan
2015-12-25 15:04 ` [Qemu-devel] [PATCH v4 3/4] expose floppy drive geometry and CMOS type Roman Kagan
2015-12-25 15:04 ` [Qemu-devel] [PATCH v4 4/4] i386: populate floppy drive information in SSDT Roman Kagan
2015-12-29 14:09 ` [Qemu-devel] [PATCH v4 0/4] i386: expose floppy-related objects " Igor Mammedov
2015-12-29 16:17 ` Roman Kagan
2015-12-29 16:27 ` Igor Mammedov
2015-12-29 16:42 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151224081532-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=den@openvz.org \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=rkagan@virtuozzo.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).