From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44521)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1aBzDl-0007HX-Ru
	for qemu-devel@nongnu.org; Thu, 24 Dec 2015 01:17:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1aBzDi-0006af-M5
	for qemu-devel@nongnu.org; Thu, 24 Dec 2015 01:17:53 -0500
Date: Thu, 24 Dec 2015 08:17:45 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20151224081532-mutt-send-email-mst@redhat.com>
References: <1450251909-1599-1-git-send-email-den@openvz.org>
	<1450467150-16227-1-git-send-email-rkagan@virtuozzo.com>
	<1450467150-16227-3-git-send-email-rkagan@virtuozzo.com>
	<20151222164147.GA30352@redhat.com>
	<20151223130817.GQ11808@rkaganb.sw.ru>
	<20151223154417-mutt-send-email-mst@redhat.com>
	<20151223150630.GA2919@rkaganb.sw.ru>
	<20151223172052.GA7374@rkaganb.sw.ru>
	<20151223184716.6a07bb0a@nial.brq.redhat.com>
	<20151223175143.GA2767@rkaganb.sw.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151223175143.GA2767@rkaganb.sw.ru>
Subject: Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for
 floppy changes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Roman Kagan <rkagan@virtuozzo.com>, Igor Mammedov <imammedo@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, "Denis V. Lunev" <den@openvz.org>, qemu-stable@nongnu.org, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>, Richard Henderson <rth@twiddle.net>

On Wed, Dec 23, 2015 at 08:51:45PM +0300, Roman Kagan wrote:
> On Wed, Dec 23, 2015 at 06:47:16PM +0100, Igor Mammedov wrote:
> > On Wed, 23 Dec 2015 20:20:54 +0300
> > Roman Kagan <rkagan@virtuozzo.com> wrote:
> > > > ... two 1.44M drives with bogus geometry for q35.
> > > 
> > > This one is a bug in my patch, indeed: I was tricked by FDRIVE_DRV_NONE
> > > being non-zero, and forgot to initialize the respective fields in
> > > acpi_get_misc_info() in case there is no floppy controller at all.
> > so instead of fake initialization, it's worth to make your patch
> > conditional on presence of controller after all.
> > i.e. add AML only if controller was present.
> 
> Indeed :)
> 
> Roman.

Or rather, start series with a patch making FDC conditional,
then update expected ssdt, then tweak methods within -
should not change ssdt since we don't create a floppy in
the test.

-- 
MST