From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aC3Gj-0001ee-6e for qemu-devel@nongnu.org; Thu, 24 Dec 2015 05:37:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aC3Gf-0003ef-SW for qemu-devel@nongnu.org; Thu, 24 Dec 2015 05:37:13 -0500 Date: Thu, 24 Dec 2015 19:36:04 +1100 From: David Gibson Message-ID: <20151224083604.GA3011@voom.redhat.com> References: <1450856601-4944-1-git-send-email-lizhijian@cn.fujitsu.com> <1450856601-4944-5-git-send-email-lizhijian@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5cXpu7evJfjLw2dJ" Content-Disposition: inline In-Reply-To: <1450856601-4944-5-git-send-email-lizhijian@cn.fujitsu.com> Subject: Re: [Qemu-devel] [PATCH 4/4] hw/ppc/spapr: fix spapr->kvm_type leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Li Zhijian Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf --5cXpu7evJfjLw2dJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 23, 2015 at 03:43:21PM +0800, Li Zhijian wrote: > Cc: David Gibson > Cc: Alexander Graf > Cc: qemu-ppc@nongnu.org > Signed-off-by: Li Zhijian Since the machine has a lifetime basically equal to the runtime of qemu, it's not a terribly important leak. Still, might as well get it right. Merged into my ppc-for-2.6 branch. > --- > hw/ppc/spapr.c | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 6bfb908..65b2d61 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -2101,6 +2101,13 @@ static void spapr_machine_initfn(Object *obj) > NULL); > } > =20 > +static char *spapr_machine_finalizefn(Object *obj) > +{ > + sPAPRMachineState *spapr =3D SPAPR_MACHINE(obj); > + > + g_free(spapr->kvm_type); > +} > + > static void ppc_cpu_do_nmi_on_cpu(void *arg) > { > CPUState *cs =3D arg; > @@ -2288,6 +2295,7 @@ static const TypeInfo spapr_machine_info =3D { > .abstract =3D true, > .instance_size =3D sizeof(sPAPRMachineState), > .instance_init =3D spapr_machine_initfn, > + .instance_finalize =3D spapr_machine_finalizefn, > .class_size =3D sizeof(sPAPRMachineClass), > .class_init =3D spapr_machine_class_init, > .interfaces =3D (InterfaceInfo[]) { --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --5cXpu7evJfjLw2dJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWe650AAoJEGw4ysog2bOSkToQAIhrzlO/gEoAwLv72slGVIuK Xz8ACCcbblcjK+i7Ix/m7TjSl/gUVJyy3liXa2ZMzMzON2x5Sn/0fpJxiU/aOUAZ IjdTLx1q2gilI8Wt1RAxh3xA7y49Vt830DBYt20a4HnJh8dOxVZcgw1+5klkIWVT G6KV7BlxaBis845TXjjuuzr1yhQo7n31nQq45t04VQe8w1fJkqhNcFAgrm6CY0vB JH14XU2N4WWNsxjxVXEuzbmT0EKE+azZkbpU+SFanzPbhoE9D4j+GSEMfP5k7bqS QdrpnAItNDKp9XbGXHfreTSsjne6GvxzcEhgculVqCcXlAK8QvgTmnIMaTL1ECKt EZ9KSrY57q/PO7FbqKtEJXXQEHK69xTQ7L1+PXGBDF7yyvXNxBmna52Y3KnSizuV lpvqMt1foeBSVf79OErmx8yHS2sgC7a8ijKFxA8F+U6dXb3dY/WyfhIlk4Ck+mtt wykDjWIntdSC0bFL+7P6TITFcfGBPpJqK+S8rSm1E3Xwa2d7OA7jalt/xr66ZwIL hlv3Dlv+dkBdpDX6v1mas0JMPZEiD89UgN+g+7al6/gexN2uFAU/Oww4Rh+07HsA 7NAGjvcJ7jyk/WrtMtM6SHFShx2GC02WUw8DjFUR4QAF9cqjDRxo9Jw7hZ3wYjNU zKfUfwucVIc6IE9AHCao =UDYJ -----END PGP SIGNATURE----- --5cXpu7evJfjLw2dJ--