From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47075) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGJ3N-0000xD-Lr for qemu-devel@nongnu.org; Mon, 04 Jan 2016 23:17:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGJ3M-0002qX-Qn for qemu-devel@nongnu.org; Mon, 04 Jan 2016 23:17:01 -0500 Date: Tue, 5 Jan 2016 12:16:51 +0800 From: Fam Zheng Message-ID: <20160105041650.GC7801@ad.usersys.redhat.com> References: <1450936225-4249-1-git-send-email-famz@redhat.com> <1450936225-4249-2-git-send-email-famz@redhat.com> <568ADD50.9020700@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <568ADD50.9020700@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 01/14] block: Add "file" output parameter to block status query functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-block@nongnu.org, qemu-devel@nongnu.org, Stefan Hajnoczi , pbonzini@redhat.com On Mon, 01/04 22:00, Max Reitz wrote: > On 24.12.2015 06:50, Fam Zheng wrote: > > The added parameter can be used to return the BDS pointer which the > > valid offset is referring to. It's value should be ignored unless > > *Its > > > BDRV_BLOCK_OFFSET_VALID in ret is set. > > > > Until block drivers fill in the right value, let's clear it explicitly > > right before calling .bdrv_get_block_status. > > > > Reviewed-by: Stefan Hajnoczi > > Signed-off-by: Fam Zheng > > --- > > block/io.c | 42 ++++++++++++++++++++++++++++-------------- > > block/iscsi.c | 6 ++++-- > > block/mirror.c | 3 ++- > > block/parallels.c | 2 +- > > block/qcow.c | 2 +- > > block/qcow2.c | 2 +- > > block/qed.c | 3 ++- > > block/raw-posix.c | 3 ++- > > block/raw_bsd.c | 3 ++- > > block/sheepdog.c | 2 +- > > block/vdi.c | 2 +- > > block/vmdk.c | 2 +- > > block/vpc.c | 2 +- > > block/vvfat.c | 2 +- > > include/block/block.h | 6 ++++-- > > include/block/block_int.h | 3 ++- > > qemu-img.c | 7 +++++-- > > 17 files changed, 59 insertions(+), 33 deletions(-) > > > > [...] > > > diff --git a/include/block/block.h b/include/block/block.h > > index db8e096..70b4984 100644 > > --- a/include/block/block.h > > +++ b/include/block/block.h > > The comment explaining BDRV_BLOCK_OFFSET_VALID should be changed > accordingly (you could also say "fixed", because apparently it wasn't > always bs->file; sometimes it was bs itself (in case of raw-posix, iscsi > and sheepdog)). Yes, good point! Will fix this, and the typo above. Fam