From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGMIi-0004wv-Gb for qemu-devel@nongnu.org; Tue, 05 Jan 2016 02:45:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGMIa-0001Vz-En for qemu-devel@nongnu.org; Tue, 05 Jan 2016 02:45:04 -0500 Received: from nm6-vm5.bullet.mail.gq1.yahoo.com ([98.136.218.196]:39610) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGMIa-0001Um-1s for qemu-devel@nongnu.org; Tue, 05 Jan 2016 02:44:56 -0500 Date: Tue, 5 Jan 2016 07:44:45 +0000 From: Sitsofe Wheeler Message-ID: <20160105074443.GA26667@sucs.org> References: <20151230195338.GA25149@sucs.org> <20151230195744.GA26893@sucs.org> <568AB6E3.5010302@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <568AB6E3.5010302@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-nbd: Minor texi updates List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-trivial@nongnu.org, Paolo Bonzini , qemu-devel@nongnu.org On Mon, Jan 04, 2016 at 11:16:03AM -0700, Eric Blake wrote: > On 12/30/2015 12:57 PM, Sitsofe Wheeler wrote: > > +@item -f, --format=@var{fmt} > > +force the use of the block driver for format @var{fmt} instead of > > +auto-detecting > > Why are you abbreviating 'format' to 'fmt'? Oh, because that's how the > other duplicate one was worded. The problem is who to be consistent with? There are a few choices: o qemu(1) o qemu --help o qemu-img(1) o qemu-img --help o qemu-nbd --help o (For NBD options) nbd-server(1) In the end I decided to try and avoid changing what was already there. > Should probably start with 'Force', to match the capitalization used > earlier.... > > > @item -r, --read-only > > export read-only > > @item -P, --partition=@var{num} > > @@ -44,17 +45,22 @@ the emulator's @code{-drive cache=...} option for allowed values. > > choose asynchronous I/O mode between @samp{threads} (the default) > > and @samp{native} (Linux only). > > @item --discard=@var{discard} > > -toggles whether @dfn{discard} (also known as @dfn{trim} or @dfn{unmap}) > > ...then again, later lines are not starting with upper case. Maybe > that's worth its own patch to make it uniformly consistent? OK I've posted an updated patch set with the capitalisation fixed as another patch. > > +@item --detect-zeroes=@var{detect-zeroes} > > +enables the automatic conversion of plain zero writes by the OS to driver > > +specific optimized zero write commands. @var{detect-zeroes} is one of > > I'd probably write this one as 'driver-specific' OK I've changed this in the updated patch set (although this makes things inconsistent with qemu(1)). -- Sitsofe | http://sucs.org/~sits/