From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGTTK-0003Qo-B3 for qemu-devel@nongnu.org; Tue, 05 Jan 2016 10:24:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGTTF-0001jg-8i for qemu-devel@nongnu.org; Tue, 05 Jan 2016 10:24:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGTTF-0001ja-2k for qemu-devel@nongnu.org; Tue, 05 Jan 2016 10:24:25 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id C1347C05E140 for ; Tue, 5 Jan 2016 15:24:24 +0000 (UTC) Date: Tue, 5 Jan 2016 16:24:21 +0100 From: Andrew Jones Message-ID: <20160105152421.GB4208@hawk.localdomain> References: <1452000043-23567-1-git-send-email-drjones@redhat.com> <568BD938.4040502@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <568BD938.4040502@redhat.com> Subject: Re: [Qemu-devel] [PATCH] trace-events: fix broken format strings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: pbonzini@redhat.com, qemu-devel@nongnu.org On Tue, Jan 05, 2016 at 03:54:48PM +0100, Laurent Vivier wrote: > > > On 05/01/2016 14:20, Andrew Jones wrote: > > Fixes compiling with --enable-trace-backends > > > > Signed-off-by: Andrew Jones > > --- > > trace-events | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/trace-events b/trace-events > > index 6f036384a84f8..e42898d5659d5 100644 > > --- a/trace-events > > +++ b/trace-events > > @@ -1799,15 +1799,15 @@ qcrypto_tls_session_new(void *session, void *creds, const char *hostname, const > > vhost_user_event(const char *chr, int event) "chr: %s got event: %d" > > > > # linux-user/signal.c > > -user_setup_frame(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64"" > > -user_setup_rt_frame(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64"" > > -user_do_rt_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64"" > > -user_do_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64"" > > +user_setup_frame(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64"" > > +user_setup_rt_frame(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64"" > > +user_do_rt_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64"" > > +user_do_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64"" > > I think there are too many quotes. This looks more correct: > > "env=%p frame_addr=0x%"PRIx64 You're right. The trailing null strings don't break compilation, but don't do anything either. I'll send a v2 with those removed. Thanks, drew > > > user_force_sig(void *env, int target_sig, int host_sig) "env=%p signal %d (host %d)" > > user_handle_signal(void *env, int target_sig) "env=%p signal %d" > > user_host_signal(void *env, int host_sig, int target_sig) "env=%p signal %d (target %d(" > > user_queue_signal(void *env, int target_sig) "env=%p signal %d" > > -user_s390x_restore_sigregs(void *env, uint64_t sc_psw_addr, uint64_t env_psw_addr) "env=%p frame psw.addr "PRIx64 " current psw.addr "PRIx64"" > > +user_s390x_restore_sigregs(void *env, uint64_t sc_psw_addr, uint64_t env_psw_addr) "env=%p frame psw.addr 0x%"PRIx64 " current psw.addr 0x%"PRIx64"" > > > > # io/task.c > > qio_task_new(void *task, void *source, void *func, void *opaque) "Task new task=%p source=%p func=%p opaque=%p" > > >