From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41127) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGTao-0008NE-Cm for qemu-devel@nongnu.org; Tue, 05 Jan 2016 10:32:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGTaj-00039O-EY for qemu-devel@nongnu.org; Tue, 05 Jan 2016 10:32:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34873) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGTaj-00039K-9W for qemu-devel@nongnu.org; Tue, 05 Jan 2016 10:32:09 -0500 Date: Tue, 5 Jan 2016 16:32:04 +0100 From: Andrew Jones Message-ID: <20160105153204.GC4208@hawk.localdomain> References: <1452000144-23805-1-git-send-email-drjones@redhat.com> <568BCE1A.8090007@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <568BCE1A.8090007@redhat.com> Subject: Re: [Qemu-devel] [PATCH] hw/dma/xilinx_axidma: debug printf fixups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: edgar.iglesias@gmail.com, alistair.francis@xilinx.com, qemu-devel@nongnu.org, crosthwaite.peter@gmail.com On Tue, Jan 05, 2016 at 07:07:22AM -0700, Eric Blake wrote: > On 01/05/2016 06:22 AM, Andrew Jones wrote: > > (Found by grepping for broken PRI users.) > > > > Signed-off-by: Andrew Jones > > --- > > hw/dma/xilinx_axidma.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c > > index b1cfa11356a26..2ab0772cd19ae 100644 > > --- a/hw/dma/xilinx_axidma.c > > +++ b/hw/dma/xilinx_axidma.c > > @@ -180,10 +180,10 @@ static inline int streamid_from_addr(hwaddr addr) > > #ifdef DEBUG_ENET > > static void stream_desc_show(struct SDesc *d) > > { > > - qemu_log("buffer_addr = " PRIx64 "\n", d->buffer_address); > > - qemu_log("nxtdesc = " PRIx64 "\n", d->nxtdesc); > > - qemu_log("control = %x\n", d->control); > > - qemu_log("status = %x\n", d->status); > > + qemu_log("buffer_addr = 0x%" PRIx64 "\n", d->buffer_address); > > + qemu_log("nxtdesc = 0x%" PRIx64 "\n", d->nxtdesc); > > + qemu_log("control = 0x%x\n", d->control); > > + qemu_log("status = 0x%x\n", d->status); > > This is dead code. Nothing uses stream_desc_show() even when DEBUG_ENET > is defined. I'd just delete the function and #ifdef altogether, instead. Sounds good, but I guess I'll leave the keep+fix vs. throw decision to the maintainers, rather than to submit a v2 ripping it out. Thanks, drew > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >