Re: [Qemu-devel] [PATCH] pc: allow raising low memory via max-ram-below-4g option

["Michael S. Tsirkin" <mst@redhat.com>]

On Tue, Jan 05, 2016 at 02:32:05PM +0100, Gerd Hoffmann wrote:
> On Di, 2016-01-05 at 15:17 +0200, Michael S. Tsirkin wrote:
> > On Tue, Jan 05, 2016 at 12:59:51PM +0100, Gerd Hoffmann wrote:
> > > This patch extends the functionality of the max-ram-below-4g option
> > > to also allow increasing lowmem.  While being at it also rework the
> > > lowmem calculation logic and add a longish comment describing how it
> > > works and what the compatibility constrains are.
> > > 
> > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > 
> > Could you please add info about the motivation for this
> > in the commit log?
> 
> > > +     *  - Finally max-ram-below-4g got updated to also allow raising lowmem,
> > > +     *    so legacy non-PAE guests can get as much memory as possible in
> > > +     *    the 32bit address space below 4G.
> 
> It's right here (where it imho is more useful for people looking at the
> code).

That's good.

> Want me copy this into the commit message?
> 
> cheers,
>   Gerd

Yes please do in the next revision. I do review in several passes, info
in commit log is helpful so I can decide how urgent is any given patch
and thus into which mailbox to sort it.

-- 
MST