From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGRlc-0002Ti-Cg for qemu-devel@nongnu.org; Tue, 05 Jan 2016 08:35:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGRlY-00023J-CK for qemu-devel@nongnu.org; Tue, 05 Jan 2016 08:35:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGRlY-00023D-6y for qemu-devel@nongnu.org; Tue, 05 Jan 2016 08:35:12 -0500 Date: Tue, 5 Jan 2016 15:35:08 +0200 From: "Michael S. Tsirkin" Message-ID: <20160105153248-mutt-send-email-mst@redhat.com> References: <1451995191-20572-1-git-send-email-kraxel@redhat.com> <20160105151711-mutt-send-email-mst@redhat.com> <1452000725.6030.7.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452000725.6030.7.camel@redhat.com> Subject: Re: [Qemu-devel] [PATCH] pc: allow raising low memory via max-ram-below-4g option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Paolo Bonzini , qemu-devel@nongnu.org, Eduardo Habkost , Richard Henderson On Tue, Jan 05, 2016 at 02:32:05PM +0100, Gerd Hoffmann wrote: > On Di, 2016-01-05 at 15:17 +0200, Michael S. Tsirkin wrote: > > On Tue, Jan 05, 2016 at 12:59:51PM +0100, Gerd Hoffmann wrote: > > > This patch extends the functionality of the max-ram-below-4g option > > > to also allow increasing lowmem. While being at it also rework the > > > lowmem calculation logic and add a longish comment describing how it > > > works and what the compatibility constrains are. > > > > > > Signed-off-by: Gerd Hoffmann > > > > Could you please add info about the motivation for this > > in the commit log? > > > > + * - Finally max-ram-below-4g got updated to also allow raising lowmem, > > > + * so legacy non-PAE guests can get as much memory as possible in > > > + * the 32bit address space below 4G. > > It's right here (where it imho is more useful for people looking at the > code). That's good. > Want me copy this into the commit message? > > cheers, > Gerd Yes please do in the next revision. I do review in several passes, info in commit log is helpful so I can decide how urgent is any given patch and thus into which mailbox to sort it. -- MST