From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGX8n-0005pf-8R for qemu-devel@nongnu.org; Tue, 05 Jan 2016 14:19:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGX8j-0005CR-89 for qemu-devel@nongnu.org; Tue, 05 Jan 2016 14:19:33 -0500 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:43712) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGX8i-0005Bd-VZ for qemu-devel@nongnu.org; Tue, 05 Jan 2016 14:19:29 -0500 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 5 Jan 2016 19:19:27 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 0855A1B0804B for ; Tue, 5 Jan 2016 19:20:07 +0000 (GMT) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u05JJPkN7995852 for ; Tue, 5 Jan 2016 19:19:25 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u05JJPtt029177 for ; Tue, 5 Jan 2016 12:19:25 -0700 Date: Tue, 5 Jan 2016 20:19:22 +0100 From: Greg Kurz Message-ID: <20160105201922.2b265b0c@bahia.local> In-Reply-To: <20151223172823.3601f342@bahia.local> References: <20151217085213.10306.97858.stgit@bahia.huguette.org> <20151223154626-mutt-send-email-mst@redhat.com> <20151223172823.3601f342@bahia.local> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 0/3] virtio: cross-endian helpers fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Cornelia Huck , qemu-devel@nongnu.org On Wed, 23 Dec 2015 17:28:23 +0100 Greg Kurz wrote: > On Wed, 23 Dec 2015 15:47:00 +0200 > "Michael S. Tsirkin" wrote: >=20 > > On Thu, Dec 17, 2015 at 09:52:46AM +0100, Greg Kurz wrote: > > > This series tries to rework cross-endian helpers for better clarity. > > > It does not change behaviour, except perhaps patch 3/3 even if I coul= d not > > > measure any performance gain. > >=20 > > Breaks build: > >=20 > > CC mips64-softmmu/hw/mips/mips_malta.o > > /home/mst/scm/qemu/hw/net/vhost_net.c: In function > > =E2=80=98vhost_net_set_vnet_endian=E2=80=99: > > /home/mst/scm/qemu/hw/net/vhost_net.c:208:10: error: implicit > > declaration of function =E2=80=98virtio_legacy_is_cross_endian=E2=80=99 > > [-Werror=3Dimplicit-function-declaration] > > (virtio_legacy_is_cross_endian(dev) && > > !virtio_is_big_endian(dev))) { > > ^ > > /home/mst/scm/qemu/hw/net/vhost_net.c:208:9: error: nested extern > > declaration of =E2=80=98virtio_legacy_is_cross_endian=E2=80=99 [-Werror= =3Dnested-externs] > > (virtio_legacy_is_cross_endian(dev) && > > !virtio_is_big_endian(dev))) { > > ^ > > cc1: all warnings being treated as errors > > /home/mst/scm/qemu/rules.mak:57: recipe for target 'hw/net/vhost_net.o' > > failed > > make[1]: *** [hw/net/vhost_net.o] Error 1 > > Makefile:186: recipe for target 'subdir-i386-softmmu' failed > > make: *** [subdir-i386-softmmu] Error 2 > >=20 > >=20 > > please always build all architectures. > >=20 >=20 > Ok. I'll do so from now on. >=20 The break isn't architecture related actually. It is because this series depends on the "virtio-net/vhost-net: share cross-endian enablement" series I had posted before... my bad. Since most of these series is cleanup of the cross-endian code, I'll repost a single series with all the patches. > > > --- > > >=20 > > > Greg Kurz (3): > > > virtio: move cross-endian helper to vhost > > > vhost: move virtio 1.0 check to cross-endian helper > > > virtio: optimize virtio_access_is_big_endian() for little-endia= n targets > > >=20 > > >=20 > > > hw/virtio/vhost.c | 22 ++++++++++++++++++---- > > > include/hw/virtio/virtio-access.h | 16 +++------------- > > > 2 files changed, 21 insertions(+), 17 deletions(-) > >=20 >=20 >=20