From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48174)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gkurz@linux.vnet.ibm.com>) id 1aGjXc-0002oa-S7
	for qemu-devel@nongnu.org; Wed, 06 Jan 2016 03:34:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gkurz@linux.vnet.ibm.com>) id 1aGjXY-00058A-QV
	for qemu-devel@nongnu.org; Wed, 06 Jan 2016 03:34:00 -0500
Received: from e06smtp06.uk.ibm.com ([195.75.94.102]:48325)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gkurz@linux.vnet.ibm.com>) id 1aGjXY-00055m-G7
	for qemu-devel@nongnu.org; Wed, 06 Jan 2016 03:33:56 -0500
Received: from localhost
	by e06smtp06.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <gkurz@linux.vnet.ibm.com>;
	Wed, 6 Jan 2016 08:33:54 -0000
Date: Wed, 6 Jan 2016 09:33:48 +0100
From: Greg Kurz <gkurz@linux.vnet.ibm.com>
Message-ID: <20160106093348.1c7146bb@bahia.local>
In-Reply-To: <1452068575-21543-1-git-send-email-caoj.fnst@cn.fujitsu.com>
References: <1452068575-21543-1-git-send-email-caoj.fnst@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] virtio serial port: fix to incomplete
 QOMify
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: amit.shah@redhat.com, pbonzini@redhat.com, qemu-trivial@nongnu.org, qemu-devel@nongnu.org, mst@redhat.com

On Wed, 6 Jan 2016 16:22:55 +0800
Cao jin <caoj.fnst@cn.fujitsu.com> wrote:

> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---

Reviewed-by: Greg Kurz <gkurz@linux.vnet.ibm.com>

>  hw/char/virtio-serial-bus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
> index 497b0af..2d2a659 100644
> --- a/hw/char/virtio-serial-bus.c
> +++ b/hw/char/virtio-serial-bus.c
> @@ -798,7 +798,7 @@ static const TypeInfo virtser_bus_info = {
> 
>  static void virtser_bus_dev_print(Monitor *mon, DeviceState *qdev, int indent)
>  {
> -    VirtIOSerialPort *port = DO_UPCAST(VirtIOSerialPort, dev, qdev);
> +    VirtIOSerialPort *port = VIRTIO_SERIAL_PORT(qdev);
> 
>      monitor_printf(mon, "%*sport %d, guest %s, host %s, throttle %s\n",
>                     indent, "", port->id,