From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43233) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGlyA-0004Mh-0X for qemu-devel@nongnu.org; Wed, 06 Jan 2016 06:09:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGly6-0004ek-Hy for qemu-devel@nongnu.org; Wed, 06 Jan 2016 06:09:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45927) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGly6-0004eV-CF for qemu-devel@nongnu.org; Wed, 06 Jan 2016 06:09:30 -0500 Date: Wed, 6 Jan 2016 13:09:27 +0200 From: "Michael S. Tsirkin" Message-ID: <20160106130852-mutt-send-email-mst@redhat.com> References: <20151217085213.10306.97858.stgit@bahia.huguette.org> <20151223154626-mutt-send-email-mst@redhat.com> <20151223172823.3601f342@bahia.local> <20160105201922.2b265b0c@bahia.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160105201922.2b265b0c@bahia.local> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 0/3] virtio: cross-endian helpers fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: Cornelia Huck , qemu-devel@nongnu.org On Tue, Jan 05, 2016 at 08:19:22PM +0100, Greg Kurz wrote: > On Wed, 23 Dec 2015 17:28:23 +0100 > Greg Kurz wrote: >=20 > > On Wed, 23 Dec 2015 15:47:00 +0200 > > "Michael S. Tsirkin" wrote: > >=20 > > > On Thu, Dec 17, 2015 at 09:52:46AM +0100, Greg Kurz wrote: > > > > This series tries to rework cross-endian helpers for better clari= ty. > > > > It does not change behaviour, except perhaps patch 3/3 even if I = could not > > > > measure any performance gain. > > >=20 > > > Breaks build: > > >=20 > > > CC mips64-softmmu/hw/mips/mips_malta.o > > > /home/mst/scm/qemu/hw/net/vhost_net.c: In function > > > =E2=80=98vhost_net_set_vnet_endian=E2=80=99: > > > /home/mst/scm/qemu/hw/net/vhost_net.c:208:10: error: implicit > > > declaration of function =E2=80=98virtio_legacy_is_cross_endian=E2=80= =99 > > > [-Werror=3Dimplicit-function-declaration] > > > (virtio_legacy_is_cross_endian(dev) && > > > !virtio_is_big_endian(dev))) { > > > ^ > > > /home/mst/scm/qemu/hw/net/vhost_net.c:208:9: error: nested extern > > > declaration of =E2=80=98virtio_legacy_is_cross_endian=E2=80=99 [-We= rror=3Dnested-externs] > > > (virtio_legacy_is_cross_endian(dev) && > > > !virtio_is_big_endian(dev))) { > > > ^ > > > cc1: all warnings being treated as errors > > > /home/mst/scm/qemu/rules.mak:57: recipe for target 'hw/net/vhost_ne= t.o' > > > failed > > > make[1]: *** [hw/net/vhost_net.o] Error 1 > > > Makefile:186: recipe for target 'subdir-i386-softmmu' failed > > > make: *** [subdir-i386-softmmu] Error 2 > > >=20 > > >=20 > > > please always build all architectures. > > >=20 > >=20 > > Ok. I'll do so from now on. > >=20 >=20 > The break isn't architecture related actually. It is because this serie= s > depends on the "virtio-net/vhost-net: share cross-endian enablement" se= ries > I had posted before... my bad. Since most of these series is cleanup of= the > cross-endian code, Oh. And I thought it's the reverse order somehow. > I'll repost a single series with all the patches. That's probably best. > > > > --- > > > >=20 > > > > Greg Kurz (3): > > > > virtio: move cross-endian helper to vhost > > > > vhost: move virtio 1.0 check to cross-endian helper > > > > virtio: optimize virtio_access_is_big_endian() for little-e= ndian targets > > > >=20 > > > >=20 > > > > hw/virtio/vhost.c | 22 ++++++++++++++++++---- > > > > include/hw/virtio/virtio-access.h | 16 +++------------- > > > > 2 files changed, 21 insertions(+), 17 deletions(-) > > >=20 > >=20 > >=20