From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGpVr-0001ZJ-9E for qemu-devel@nongnu.org; Wed, 06 Jan 2016 09:56:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGpVm-0001Th-A2 for qemu-devel@nongnu.org; Wed, 06 Jan 2016 09:56:35 -0500 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:55612) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGpVm-0001TQ-0P for qemu-devel@nongnu.org; Wed, 06 Jan 2016 09:56:30 -0500 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 6 Jan 2016 14:56:26 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id B0A5517D8056 for ; Wed, 6 Jan 2016 14:56:43 +0000 (GMT) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u06Etw979044320 for ; Wed, 6 Jan 2016 14:55:58 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u06Etvqn015502 for ; Wed, 6 Jan 2016 07:55:58 -0700 Date: Wed, 6 Jan 2016 15:55:54 +0100 From: Greg Kurz Message-ID: <20160106155554.60492fc0@bahia.local> In-Reply-To: <1452015002-28493-4-git-send-email-clg@fr.ibm.com> References: <1452015002-28493-4-git-send-email-clg@fr.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/8] ipmi: add GET_SYS_RESTART_CAUSE chassis command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?Q8OpZHJpYw==?= Le Goater Cc: Corey Minyard , qemu-devel@nongnu.org, "Michael S. Tsirkin" On Tue, 5 Jan 2016 18:29:57 +0100 C=C3=A9dric Le Goater wrote: > This is a simulator. Just return an unknown cause (0). >=20 > Signed-off-by: C=C3=A9dric Le Goater > --- Acked-by: Greg Kurz > hw/ipmi/ipmi_bmc_sim.c | 20 ++++++++++++++++++-- > 1 file changed, 18 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c > index 061db8437479..5db94491b130 100644 > --- a/hw/ipmi/ipmi_bmc_sim.c > +++ b/hw/ipmi/ipmi_bmc_sim.c > @@ -30,11 +30,12 @@ > #include "qemu/error-report.h" >=20 > #define IPMI_NETFN_CHASSIS 0x00 > -#define IPMI_NETFN_CHASSIS_MAXCMD 0x03 > +#define IPMI_NETFN_CHASSIS_MAXCMD 0x0a >=20 No big deal again but I guess the define would better fit... > #define IPMI_CMD_GET_CHASSIS_CAPABILITIES 0x00 > #define IPMI_CMD_GET_CHASSIS_STATUS 0x01 > #define IPMI_CMD_CHASSIS_CONTROL 0x02 > +#define IPMI_CMD_GET_SYS_RESTART_CAUSE 0x09 >=20 ... here. > #define IPMI_NETFN_SENSOR_EVENT 0x04 > #define IPMI_NETFN_SENSOR_EVENT_MAXCMD 0x30 > @@ -201,6 +202,8 @@ struct IPMIBmcSim { > uint8_t mfg_id[3]; > uint8_t product_id[2]; >=20 > + uint8_t restart_cause; > + > IPMISel sel; > IPMISdr sdr; > IPMISensor sensors[MAX_SENSORS]; > @@ -754,6 +757,17 @@ static void chassis_control(IPMIBmcSim *ibs, > return; > } >=20 > +static void chassis_get_sys_restart_cause(IPMIBmcSim *ibs, > + uint8_t *cmd, unsigned int cmd_len, > + uint8_t *rsp, unsigned int *rsp_len, > + unsigned int max_rsp_len) > +{ > + IPMI_ADD_RSP_DATA(ibs->restart_cause & 0xf); /* Restart Cause */ Define a mask ? > + IPMI_ADD_RSP_DATA(0); /* Channel 0 */ > + out: > + return; > +} > + > static void get_device_id(IPMIBmcSim *ibs, > uint8_t *cmd, unsigned int cmd_len, > uint8_t *rsp, unsigned int *rsp_len, > @@ -1624,7 +1638,8 @@ static void get_sensor_type(IPMIBmcSim *ibs, > static const IPMICmdHandler chassis_cmds[IPMI_NETFN_CHASSIS_MAXCMD] =3D { > [IPMI_CMD_GET_CHASSIS_CAPABILITIES] =3D chassis_capabilities, > [IPMI_CMD_GET_CHASSIS_STATUS] =3D chassis_status, > - [IPMI_CMD_CHASSIS_CONTROL] =3D chassis_control > + [IPMI_CMD_CHASSIS_CONTROL] =3D chassis_control, > + [IPMI_CMD_GET_SYS_RESTART_CAUSE] =3D chassis_get_sys_restart_cause > }; > static const IPMINetfn chassis_netfn =3D { > .cmd_nums =3D IPMI_NETFN_CHASSIS_MAXCMD, > @@ -1746,6 +1761,7 @@ static void ipmi_sim_init(Object *obj) > ibs->bmc_global_enables =3D (1 << IPMI_BMC_EVENT_LOG_BIT); > ibs->device_id =3D 0x20; > ibs->ipmi_version =3D 0x02; /* IPMI 2.0 */ > + ibs->restart_cause =3D 0; > for (i =3D 0; i < 4; i++) { > ibs->sel.last_addition[i] =3D 0xff; > ibs->sel.last_clear[i] =3D 0xff;