From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aH3WF-0007lr-N4 for qemu-devel@nongnu.org; Thu, 07 Jan 2016 00:53:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aH3WB-0008Ir-MU for qemu-devel@nongnu.org; Thu, 07 Jan 2016 00:53:55 -0500 Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:10488) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aH3WB-0008Ia-Gd for qemu-devel@nongnu.org; Thu, 07 Jan 2016 00:53:51 -0500 Date: Wed, 6 Jan 2016 21:53:49 -0800 From: Ashok Kumar Message-ID: <20160107055348.GF28462@ashoks@broadcom.com> References: <1452091659-17698-1-git-send-email-ashoks@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] hw/arm/virt: Initialize NICs configured in PCI bus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers On Wed, Jan 06, 2016 at 06:10:15PM +0000, Peter Maydell wrote: Hi, > On 6 January 2016 at 14:47, Ashok Kumar wrote: > > virtio model is used for default case. > > > > Signed-off-by: Ashok Kumar > > Could you explain why you think this needs to be done? Yes, for -net. Honestly, I didn't know this is obsolete and the only syntax I knew for networking. > Virtio networking works OK for me... I tried the new syntax now and it is working fine. > > I guess from the patch that this is adding support for > the legacy '-net' way of configuring networking, but do > we need that if we never supported it in the first place? > (If virt is the only PCI machine which doesn't support > -net syntax that would probably be a strong argument for > supporting it.) Fine with me. But there are some documentation for e.g [1] which says "-net" is still supported. [1] http://www.linux-kvm.org/page/Networking#Compatibility Thanks, Ashok > > thanks > -- PMM >