Re: [Qemu-devel] [PATCH v2 09/10] trace: [tcg] Add per-vCPU tracing states for events with the 'vcpu' property

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 895 bytes --]

On Tue, Nov 24, 2015 at 06:09:36PM +0100, Lluís Vilanova wrote:
> +    /* Ensure 'tb_phys_idx' can encode event states as a bitmask */
> +    bool too_many_tcg_vcpu_events[
> +        TRACE_CPU_EVENT_COUNT > sizeof(unsigned int)*8 ? -1 : 0];

There is a limit of 32 vcpu tcg events?  That seems low but as long as
not too many users of this feature are merged it will work...

> @@ -227,6 +228,17 @@ void cpu_dump_statistics(CPUState *cpu, FILE *f, fprintf_function cpu_fprintf,
>  void cpu_reset(CPUState *cpu)
>  {
>      CPUClass *klass = CPU_GET_CLASS(cpu);
> +    TraceEvent *ev = NULL;
> +
> +    if (!qemu_initialized) {

Is there a cleaner place to do this without introducing the
qemu_initialized global?

I guess the problem is that tracing itself is initialized before the
vcpus are set up.  Is qemu_add_machine_init_done_notifier() sufficient
for this purpose?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]