From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43697) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aH7KF-0001bn-1v for qemu-devel@nongnu.org; Thu, 07 Jan 2016 04:57:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aH7KA-0005wu-E8 for qemu-devel@nongnu.org; Thu, 07 Jan 2016 04:57:46 -0500 Date: Thu, 7 Jan 2016 15:27:37 +0530 From: Amit Shah Message-ID: <20160107095737.GA17885@grmbl.mre> References: <1452068575-21543-1-git-send-email-caoj.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452068575-21543-1-git-send-email-caoj.fnst@cn.fujitsu.com> Subject: Re: [Qemu-devel] [PATCH] virtio serial port: fix to incomplete QOMify List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, qemu-devel@nongnu.org, mst@redhat.com On (Wed) 06 Jan 2016 [16:22:55], Cao jin wrote: > Signed-off-by: Cao jin > --- > hw/char/virtio-serial-bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c > index 497b0af..2d2a659 100644 > --- a/hw/char/virtio-serial-bus.c > +++ b/hw/char/virtio-serial-bus.c > @@ -798,7 +798,7 @@ static const TypeInfo virtser_bus_info = { > > static void virtser_bus_dev_print(Monitor *mon, DeviceState *qdev, int indent) > { > - VirtIOSerialPort *port = DO_UPCAST(VirtIOSerialPort, dev, qdev); > + VirtIOSerialPort *port = VIRTIO_SERIAL_PORT(qdev); > > monitor_printf(mon, "%*sport %d, guest %s, host %s, throttle %s\n", > indent, "", port->id, Reviewed-by: Amit Shah Applied to my tree, thanks. Amit