* [Qemu-devel] [PATCH] virtio serial port: fix to incomplete QOMify
@ 2016-01-06 8:22 Cao jin
2016-01-06 8:33 ` Greg Kurz
2016-01-07 9:57 ` Amit Shah
0 siblings, 2 replies; 3+ messages in thread
From: Cao jin @ 2016-01-06 8:22 UTC (permalink / raw)
To: qemu-devel; +Cc: amit.shah, pbonzini, qemu-trivial, mst
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
hw/char/virtio-serial-bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
index 497b0af..2d2a659 100644
--- a/hw/char/virtio-serial-bus.c
+++ b/hw/char/virtio-serial-bus.c
@@ -798,7 +798,7 @@ static const TypeInfo virtser_bus_info = {
static void virtser_bus_dev_print(Monitor *mon, DeviceState *qdev, int indent)
{
- VirtIOSerialPort *port = DO_UPCAST(VirtIOSerialPort, dev, qdev);
+ VirtIOSerialPort *port = VIRTIO_SERIAL_PORT(qdev);
monitor_printf(mon, "%*sport %d, guest %s, host %s, throttle %s\n",
indent, "", port->id,
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] virtio serial port: fix to incomplete QOMify
2016-01-06 8:22 [Qemu-devel] [PATCH] virtio serial port: fix to incomplete QOMify Cao jin
@ 2016-01-06 8:33 ` Greg Kurz
2016-01-07 9:57 ` Amit Shah
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kurz @ 2016-01-06 8:33 UTC (permalink / raw)
To: Cao jin; +Cc: amit.shah, pbonzini, qemu-trivial, qemu-devel, mst
On Wed, 6 Jan 2016 16:22:55 +0800
Cao jin <caoj.fnst@cn.fujitsu.com> wrote:
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
Reviewed-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
> hw/char/virtio-serial-bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
> index 497b0af..2d2a659 100644
> --- a/hw/char/virtio-serial-bus.c
> +++ b/hw/char/virtio-serial-bus.c
> @@ -798,7 +798,7 @@ static const TypeInfo virtser_bus_info = {
>
> static void virtser_bus_dev_print(Monitor *mon, DeviceState *qdev, int indent)
> {
> - VirtIOSerialPort *port = DO_UPCAST(VirtIOSerialPort, dev, qdev);
> + VirtIOSerialPort *port = VIRTIO_SERIAL_PORT(qdev);
>
> monitor_printf(mon, "%*sport %d, guest %s, host %s, throttle %s\n",
> indent, "", port->id,
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] virtio serial port: fix to incomplete QOMify
2016-01-06 8:22 [Qemu-devel] [PATCH] virtio serial port: fix to incomplete QOMify Cao jin
2016-01-06 8:33 ` Greg Kurz
@ 2016-01-07 9:57 ` Amit Shah
1 sibling, 0 replies; 3+ messages in thread
From: Amit Shah @ 2016-01-07 9:57 UTC (permalink / raw)
To: Cao jin; +Cc: qemu-trivial, pbonzini, qemu-devel, mst
On (Wed) 06 Jan 2016 [16:22:55], Cao jin wrote:
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> hw/char/virtio-serial-bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
> index 497b0af..2d2a659 100644
> --- a/hw/char/virtio-serial-bus.c
> +++ b/hw/char/virtio-serial-bus.c
> @@ -798,7 +798,7 @@ static const TypeInfo virtser_bus_info = {
>
> static void virtser_bus_dev_print(Monitor *mon, DeviceState *qdev, int indent)
> {
> - VirtIOSerialPort *port = DO_UPCAST(VirtIOSerialPort, dev, qdev);
> + VirtIOSerialPort *port = VIRTIO_SERIAL_PORT(qdev);
>
> monitor_printf(mon, "%*sport %d, guest %s, host %s, throttle %s\n",
> indent, "", port->id,
Reviewed-by: Amit Shah <amit.shah@redhat.com>
Applied to my tree, thanks.
Amit
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-07 9:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-06 8:22 [Qemu-devel] [PATCH] virtio serial port: fix to incomplete QOMify Cao jin
2016-01-06 8:33 ` Greg Kurz
2016-01-07 9:57 ` Amit Shah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).