Re: [Qemu-devel] [PATCH v3 00/11] simplify usage of tracepoints, and connect them to logging

["Edgar E. Iglesias" <edgar.iglesias@gmail.com>]

On Thu, Jan 07, 2016 at 03:40:01PM +0300, Denis V. Lunev wrote:
> On 01/07/2016 12:58 PM, Stefan Hajnoczi wrote:
> 
> [skipped]
> 
> >3.
> >I also now get a handful of extra warnings in the 'make check' output:
> >
> >   /aarch64/qom/xilinx-zynq-a9:                                         OK
> >   /aarch64/qom/xlnx-ep108:
> >WARNING: RAM size 8000000 is small for EP108OK
> I do not observe this problem.
> 
> >   /aarch64/qom/vexpress-a9:                                            OK
> >
> >(note the missing newline...)
> >
> >TEST: tests/qom-test... (pid=19738)
> >   /microblaze/qom/none:                                                OK
> >   /microblaze/qom/petalogix-s3adsp1800:
> >Invalid MicroBlaze version number: (null)
> >OK
> >   /microblaze/qom/petalogix-ml605:
> >Invalid MicroBlaze version number: (null)
> >OK
> This problem exists in the original code.
> The patchset just reveals something hidden.
> 
> This patch aborts() on unmodified sources.
> Edgar, do you have any opinion?

Hi,

Yes, there was a fix for the Microblaze issues on the list. I've just merged it.

The ZynqMP EP108 issue had another fix posted on list IIRC.

Cheers,
Edgar


> 
> Den
> 
> diff --git a/target-microblaze/cpu.c b/target-microblaze/cpu.c
> index 52959e1..fae8ef6 100644
> --- a/target-microblaze/cpu.c
> +++ b/target-microblaze/cpu.c
> @@ -167,6 +167,7 @@ static void mb_cpu_realizefn(DeviceState *dev,
> Error **errp)
> 
>      if (!version_code) {
>          qemu_log("Invalid MicroBlaze version number: %s\n",
> cpu->cfg.version);
> +        abort();
>      }
> 
>      env->pvr.regs[0] |= (cpu->cfg.stackprot ? PVR0_SPROT_MASK : 0) |