From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42537)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1aHBFN-0002op-HA
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 09:09:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1aHBFI-00022P-EP
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 09:09:01 -0500
Received: from mail-pa0-x229.google.com ([2607:f8b0:400e:c03::229]:33939)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1aHBFI-00022I-8d
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 09:08:56 -0500
Received: by mail-pa0-x229.google.com with SMTP id uo6so241378904pac.1
	for <qemu-devel@nongnu.org>; Thu, 07 Jan 2016 06:08:56 -0800 (PST)
Date: Thu, 7 Jan 2016 15:08:51 +0100
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20160107140851.GA29396@toto>
References: <1446151457-21157-1-git-send-email-den@openvz.org>
	<20160107095856.GA17701@stefanha-x1.localdomain>
	<568E5CA1.2050303@openvz.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <568E5CA1.2050303@openvz.org>
Subject: Re: [Qemu-devel] [PATCH v3 00/11] simplify usage of tracepoints,
 and connect them to logging
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>

On Thu, Jan 07, 2016 at 03:40:01PM +0300, Denis V. Lunev wrote:
> On 01/07/2016 12:58 PM, Stefan Hajnoczi wrote:
> 
> [skipped]
> 
> >3.
> >I also now get a handful of extra warnings in the 'make check' output:
> >
> >   /aarch64/qom/xilinx-zynq-a9:                                         OK
> >   /aarch64/qom/xlnx-ep108:
> >WARNING: RAM size 8000000 is small for EP108OK
> I do not observe this problem.
> 
> >   /aarch64/qom/vexpress-a9:                                            OK
> >
> >(note the missing newline...)
> >
> >TEST: tests/qom-test... (pid=19738)
> >   /microblaze/qom/none:                                                OK
> >   /microblaze/qom/petalogix-s3adsp1800:
> >Invalid MicroBlaze version number: (null)
> >OK
> >   /microblaze/qom/petalogix-ml605:
> >Invalid MicroBlaze version number: (null)
> >OK
> This problem exists in the original code.
> The patchset just reveals something hidden.
> 
> This patch aborts() on unmodified sources.
> Edgar, do you have any opinion?

Hi,

Yes, there was a fix for the Microblaze issues on the list. I've just merged it.

The ZynqMP EP108 issue had another fix posted on list IIRC.

Cheers,
Edgar


> 
> Den
> 
> diff --git a/target-microblaze/cpu.c b/target-microblaze/cpu.c
> index 52959e1..fae8ef6 100644
> --- a/target-microblaze/cpu.c
> +++ b/target-microblaze/cpu.c
> @@ -167,6 +167,7 @@ static void mb_cpu_realizefn(DeviceState *dev,
> Error **errp)
> 
>      if (!version_code) {
>          qemu_log("Invalid MicroBlaze version number: %s\n",
> cpu->cfg.version);
> +        abort();
>      }
> 
>      env->pvr.regs[0] |= (cpu->cfg.stackprot ? PVR0_SPROT_MASK : 0) |