From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHApI-0004IU-AP for qemu-devel@nongnu.org; Thu, 07 Jan 2016 08:42:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHApE-0002hS-9U for qemu-devel@nongnu.org; Thu, 07 Jan 2016 08:42:04 -0500 Received: from e06smtp05.uk.ibm.com ([195.75.94.101]:56489) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHApD-0002hI-VO for qemu-devel@nongnu.org; Thu, 07 Jan 2016 08:42:00 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 7 Jan 2016 13:41:58 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 687D417D8059 for ; Thu, 7 Jan 2016 13:42:42 +0000 (GMT) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u07DfuUr57081986 for ; Thu, 7 Jan 2016 13:41:56 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u07DfuVJ006748 for ; Thu, 7 Jan 2016 06:41:56 -0700 Date: Thu, 7 Jan 2016 14:41:42 +0100 From: Cornelia Huck Message-ID: <20160107144142.7a7556a3.cornelia.huck@de.ibm.com> In-Reply-To: <20151215105635.2a9ea70c.cornelia.huck@de.ibm.com> References: <1449749584-23214-1-git-send-email-frankja@linux.vnet.ibm.com> <20151215105635.2a9ea70c.cornelia.huck@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/34] kvm_stat: Cleanup and fixup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Janosch Frank On Tue, 15 Dec 2015 10:56:35 +0100 Cornelia Huck wrote: > On Thu, 10 Dec 2015 13:12:30 +0100 > Janosch Frank wrote: > > > Kvm_stat is a very helpful script for checking the state of VMs, but > > when I tried to introduce new features it broke every few lines. > > > > This patch series aims to make the script more readable and durable, > > so future additions to it will break it less likely. It also fixes > > input/output problems for all of its interface modes. > > > > Testing was done rarely on X86_64 RHEL 6.7 and mostly on s390. Tests > > on other architectures would be beneficial. > > The cleanup and fixes look good to me, but I'm most certainly not a > python expert :) > > Paolo, would you take these through the kvm tree? Anybody interested in these? I can't really comment on python stuff, but it would be a shame if these patches were left out in the cold... > > > > > Janosch Frank (34): > > scripts/kvm/kvm_stat: Cleanup of multiple imports > > scripts/kvm/kvm_stat: Replaced os.listdir with os.walk > > scripts/kvm/kvm_stat: Make constants uppercase > > scripts/kvm/kvm_stat: Removed unneeded PERF constants > > scripts/kvm/kvm_stat: Mark globals in functions > > scripts/kvm/kvm_stat: Invert dictionaries > > scripts/kvm/kvm_stat: Cleanup of path variables > > scripts/kvm/kvm_stat: Improve debugfs access checking > > scripts/kvm/kvm_stat: Introduce main function > > scripts/kvm/kvm_stat: Fix spaces around keyword assignments > > scripts/kvm/kvm_stat: Rename variables that redefine globals > > scripts/kvm/kvm_stat: Moved DebugfsProvider > > scripts/kvm/kvm_stat: Fixup syscall error reporting > > scripts/kvm/kvm_stat: Set sensible no. files rlimit > > scripts/kvm/kvm_stat: Cleanup of platform detection > > scripts/kvm/kvm_stat: Make cpu detection a function > > scripts/kvm/kvm_stat: Rename _perf_event_open > > scripts/kvm/kvm_stat: Introduce properties for providers > > scripts/kvm/kvm_stat: Cleanup of TracepointProvider > > scripts/kvm/kvm_stat: Cleanup cpu list retrieval > > scripts/kvm/kvm_stat: Encapsulate filters variable > > scripts/kvm/kvm_stat: Cleanup of Stats class > > scripts/kvm/kvm_stat: Cleanup of Groups class > > scripts/kvm/kvm_stat: Cleanup of Event class > > scripts/kvm/kvm_stat: Group arch specific data > > scripts/kvm/kvm_stat: Remove unneeded X86_EXIT_REASONS > > scripts/kvm/kvm_stat: Make tui function a class > > scripts/kvm/kvm_stat: Fix output formatting > > scripts/kvm/kvm_stat: Move to argparse and add description > > scripts/kvm/kvm_stat: Cleanup and pre-init perf_event_attr > > scripts/kvm/kvm_stat: Read event values as u64 > > scripts/kvm/kvm_stat: Fix rlimit for unprivileged users > > scripts/kvm/kvm_stat: Fixup filtering > > scripts/kvm/kvm_stat: Add interactive filtering > > > > scripts/kvm/kvm_stat | 1129 ++++++++++++++++++++++++++++---------------------- > > 1 file changed, 626 insertions(+), 503 deletions(-) > > >