From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58623)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=80755c3b3=wei.liu2@citrix.com>)
	id 1aHDyC-0002qZ-VM
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:03:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <prvs=80755c3b3=wei.liu2@citrix.com>)
	id 1aHDy8-0004TD-Oe
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:03:28 -0500
Received: from smtp02.citrix.com ([66.165.176.63]:2552)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=80755c3b3=wei.liu2@citrix.com>)
	id 1aHDy8-0004Sp-CG
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:03:24 -0500
Date: Thu, 7 Jan 2016 17:03:16 +0000
From: Wei Liu <wei.liu2@citrix.com>
Message-ID: <20160107170316.GC1457@citrix.com>
References: <1452020761-24457-1-git-send-email-wei.liu2@citrix.com>
	<1452020761-24457-13-git-send-email-wei.liu2@citrix.com>
	<87h9ipqqqc.fsf@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <87h9ipqqqc.fsf@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 12/22] 9pfs: use V9fsBlob to transmit xattr
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Greg Kurz <gkurz@linux.vnet.ibm.com>, Wei Liu <wei.liu2@citrix.com>, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

On Thu, Jan 07, 2016 at 10:19:47PM +0530, Aneesh Kumar K.V wrote:
> Wei Liu <wei.liu2@citrix.com> writes:
> 
> > And make v9fs_pack static function. Now we only need to export
> > v9fs_{,un}marshal to device.
> 
> 
> Any advantage of doing this ? compared to v9fs_pack ?. Trying to
> understand if i am missing something here 
> 

The reason for exporting v9fs_pack is because there is no abstraction of
blob in marshalling interface. We should fix marshalling functions
instead of leaking v9fs_pack to device.

As said in the commit message, with this change now we only need to
export v9fs_marshal and v9fs_unmarshal to device. That's a much cleaner
interface.

Wei.