From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHE2O-0007KX-2F for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:07:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHE2J-0005zq-S7 for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:07:47 -0500 Received: from smtp.citrix.com ([66.165.176.89]:11078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHE2J-0005zj-KP for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:07:43 -0500 Date: Thu, 7 Jan 2016 17:07:40 +0000 From: Wei Liu Message-ID: <20160107170740.GD1457@citrix.com> References: <1452020761-24457-1-git-send-email-wei.liu2@citrix.com> <1452020761-24457-11-git-send-email-wei.liu2@citrix.com> <87k2nlqr23.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <87k2nlqr23.fsf@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH 10/22] fsdev: break out 9p-marshal.{c, h} from virtio-9p-marshal.{c, h} List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Aneesh Kumar K.V" Cc: Wei Liu , qemu-devel@nongnu.org, Greg Kurz On Thu, Jan 07, 2016 at 10:12:44PM +0530, Aneesh Kumar K.V wrote: > Wei Liu writes: > > > Break out some generic functions for marshaling 9p state. Pure code > > motion plus minor fixes for build system. > > > > Signed-off-by: Wei Liu > > --- > > Makefile | 2 +- > > fsdev/9p-marshal.c | 57 ++++++++++++++++++++++++++++++++ > > fsdev/9p-marshal.h | 84 +++++++++++++++++++++++++++++++++++++++++++++++ > > fsdev/Makefile.objs | 2 +- > > fsdev/virtio-9p-marshal.c | 31 ----------------- > > fsdev/virtio-9p-marshal.h | 79 +------------------------------------------- > > 6 files changed, 144 insertions(+), 111 deletions(-) > > create mode 100644 fsdev/9p-marshal.c > > create mode 100644 fsdev/9p-marshal.h > > > > diff --git a/Makefile b/Makefile > > index 82b2fc8..7e881d8 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -240,7 +240,7 @@ qemu-io$(EXESUF): qemu-io.o $(block-obj-y) $(crypto-obj-y) $(qom-obj-y) libqemuu > > > > qemu-bridge-helper$(EXESUF): qemu-bridge-helper.o > > > > -fsdev/virtfs-proxy-helper$(EXESUF): fsdev/virtfs-proxy-helper.o fsdev/virtio-9p-marshal.o libqemuutil.a libqemustub.a > > +fsdev/virtfs-proxy-helper$(EXESUF): fsdev/virtfs-proxy-helper.o fsdev/9p-marshal.o fsdev/virtio-9p-marshal.o libqemuutil.a libqemustub.a > > fsdev/virtfs-proxy-helper$(EXESUF): LIBS += -lcap > > > > qemu-img-cmds.h: $(SRC_PATH)/qemu-img-cmds.hx > > diff --git a/fsdev/9p-marshal.c b/fsdev/9p-marshal.c > > new file mode 100644 > > index 0000000..610978e > > --- /dev/null > > +++ b/fsdev/9p-marshal.c > > @@ -0,0 +1,57 @@ > > +/* > > + * 9p backend > > + * > > + * Copyright IBM, Corp. 2010 > > + * > > + * Authors: > > + * Anthony Liguori > > + * Wei Liu > > > If it is just code movement just retain the authors as it is ? > I think this is residual of rebasing. I will remove this. Wei. > > + * > > + * This work is licensed under the terms of the GNU GPL, version 2. See > > + * the COPYING file in the top-level directory. > > + * > > + */ > > + > > -aneesh >