From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHEA1-0004UW-Pi for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:15:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHE9w-0008Fy-41 for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:15:41 -0500 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:33434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHE9v-0008Fj-PB for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:15:36 -0500 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 7 Jan 2016 17:15:34 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4AF32219005E for ; Thu, 7 Jan 2016 17:15:20 +0000 (GMT) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u07HFUQG2294230 for ; Thu, 7 Jan 2016 17:15:30 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u07HFTSv030988 for ; Thu, 7 Jan 2016 10:15:30 -0700 Date: Thu, 7 Jan 2016 18:15:26 +0100 From: Greg Kurz Message-ID: <20160107181526.5dc7019b@bahia.local> In-Reply-To: <877fjlqpz9.fsf@linux.vnet.ibm.com> References: <1452020761-24457-1-git-send-email-wei.liu2@citrix.com> <20160107133243.509cc369@bahia.local> <877fjlqpz9.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/22] 9pfs: disentangling virtio and generic code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Aneesh Kumar K.V" Cc: "Michael S. Tsirkin" , Wei Liu , qemu-devel@nongnu.org, Stefano Stabellini On Thu, 07 Jan 2016 22:36:02 +0530 "Aneesh Kumar K.V" wrote: > Greg Kurz writes: > > > On Thu, 7 Jan 2016 11:59:22 +0000 > > Stefano Stabellini wrote: > > > >> On Tue, 5 Jan 2016, Wei Liu wrote: > >> > Hi all > >> > > >> > Back in 2015 summer one of our OPW interns Linda Jacobson explored the > >> > possibility of making 9pfs work on Xen. It turned out lots of code in QEMU can > >> > be reused. > >> > > >> > This series refactors 9pfs related code: > >> > > >> > 1. Rename a bunch of files and functions to make clear they are generic. > >> > 2. Only export two functions (marshal and unmarshal) from transport to generic > >> > code. > >> > 3. disentangle virtio transport code and generic 9pfs code. > >> > 4. Some function name clean-up. > >> > >> The series looks pretty good and it looks like a clean improvement over > >> the current code base. > >> > > > > I agree Wei did a great job. I'll fix the title in patch 3 and push it to > > my tree next week. > > > > I will like to push this myself. I will need some time to get some > testing done with the changes. We also need some fixup with respect to fd > reclaim. > > -aneesh Sure ! Please go ahead. -- Greg