From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42045)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shmulik.ladkani@ravellosystems.com>)
	id 1aHFxX-0004zB-9m
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 14:10:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <shmulik.ladkani@ravellosystems.com>)
	id 1aHFxU-0007es-28
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 14:10:55 -0500
Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]:32821)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shmulik.ladkani@ravellosystems.com>)
	id 1aHFxT-0007ei-QA
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 14:10:51 -0500
Received: by mail-wm0-x22b.google.com with SMTP id f206so110053151wmf.0
	for <qemu-devel@nongnu.org>; Thu, 07 Jan 2016 11:10:51 -0800 (PST)
Date: Thu, 7 Jan 2016 21:10:47 +0200
From: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
Message-ID: <20160107211047.16109674@halley>
In-Reply-To: <568E9653.8070506@redhat.com>
References: <1450423803-12839-1-git-send-email-shmulik.ladkani@ravellosystems.com>
	<1450423803-12839-2-git-send-email-shmulik.ladkani@ravellosystems.com>
	<20151223212139.2c8f7beb@halley> <568E929C.3080504@redhat.com>
	<20160107173311.547748b7.cornelia.huck@de.ibm.com>
	<568E9653.8070506@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] compat: Introduce HW_COMPAT_2_5
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>, idan.brown@ravellosystems.com, qemu-devel@nongnu.org, Dmitry Fleytman <dmitry@daynix.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, David Gibson <david@gibson.dropbear.id.au>

On Thu, 7 Jan 2016 17:46:11 +0100 Paolo Bonzini <pbonzini@redhat.com> wrote:
> Ok, so I can send Shmulik's patch doing
> 
> @@ -2,14 +2,7 @@
>  #define HW_COMPAT_H
> 
>  #define HW_COMPAT_2_5 \
> -    /* empty */
> -
> -#define HW_COMPAT_2_4 \
>      {\
> -        .driver   = "virtio-blk-device",\
> -        .property = "scsi",\
> -        .value    = "true",\
> -    },{\
>          .driver   = "pvscsi",\
>          .property = "x-old-pci-configuration",\
>          .value    = "on",\
> @@ -17,6 +10,13 @@
>          .driver   = "pvscsi",\
>          .property = "x-disable-pcie",\
>          .value    = "on",\
> +    },
> +
> +#define HW_COMPAT_2_4 \
> +    {\
> +        .driver   = "virtio-blk-device",\
> +        .property = "scsi",\
> +        .value    = "true",\
>      },{\
>          .driver   = "e1000",\
>          .property = "extra_mac_registers",\
> 
> 
> in my next pull request.

Yes; All my platform specific COMPAT introductions where either
collected by the platform maintainers, or preemptively introduced by
someone else.

Thanks,
Shmulik