From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56692)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aHMZ4-0003ba-4r
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 21:14:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aHMZ3-000329-6Y
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 21:14:06 -0500
Date: Fri, 8 Jan 2016 10:13:57 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160108021357.GB808@ad.usersys.redhat.com>
References: <1451903234-32529-1-git-send-email-famz@redhat.com>
	<1451903234-32529-3-git-send-email-famz@redhat.com>
	<568C403F.2070809@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <568C403F.2070809@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 02/13] typedefs: Add BdrvDirtyBitmap and
 HBitmapIter
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>, Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>, qemu-devel@nongnu.org, qemu-block@nongnu.org

On Tue, 01/05 17:14, John Snow wrote:
> 
> 
> On 01/04/2016 05:27 AM, Fam Zheng wrote:
> > Following patches to refactor and move block dirty bitmap code could use this.
> > 
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> >  include/qemu/typedefs.h | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h
> > index 78fe6e8..e83934e 100644
> > --- a/include/qemu/typedefs.h
> > +++ b/include/qemu/typedefs.h
> > @@ -10,6 +10,7 @@ typedef struct AddressSpace AddressSpace;
> >  typedef struct AioContext AioContext;
> >  typedef struct AllwinnerAHCIState AllwinnerAHCIState;
> >  typedef struct AudioState AudioState;
> > +typedef struct BdrvDirtyBitmap BdrvDirtyBitmap;
> >  typedef struct BlockBackend BlockBackend;
> >  typedef struct BlockBackendRootState BlockBackendRootState;
> >  typedef struct BlockDriverState BlockDriverState;
> > @@ -28,6 +29,7 @@ typedef struct EventNotifier EventNotifier;
> >  typedef struct FWCfgIoState FWCfgIoState;
> >  typedef struct FWCfgMemState FWCfgMemState;
> >  typedef struct FWCfgState FWCfgState;
> > +typedef struct HBitmapIter HBitmapIter;
> >  typedef struct HCIInfo HCIInfo;
> >  typedef struct I2CBus I2CBus;
> >  typedef struct I2SCodec I2SCodec;
> > 
> 
> Should the existing typedefs be removed?
> 
> >> include/block/block.h:typedef struct BdrvDirtyBitmap BdrvDirtyBitmap;
> >> include/block/block.h:struct HBitmapIter;
> >> include/qemu/hbitmap.h:typedef struct HBitmapIter HBitmapIter;

Yes! Will do.