From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHT12-00083r-Cj for qemu-devel@nongnu.org; Fri, 08 Jan 2016 04:07:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHT0x-0006Aw-8g for qemu-devel@nongnu.org; Fri, 08 Jan 2016 04:07:24 -0500 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:48082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHT0w-0006Ah-VQ for qemu-devel@nongnu.org; Fri, 08 Jan 2016 04:07:19 -0500 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 8 Jan 2016 09:07:17 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id A98CC17D8056 for ; Fri, 8 Jan 2016 09:08:00 +0000 (GMT) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u0897EGw9240858 for ; Fri, 8 Jan 2016 09:07:14 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u0897EdP030346 for ; Fri, 8 Jan 2016 02:07:14 -0700 Date: Fri, 8 Jan 2016 10:07:11 +0100 From: Greg Kurz Message-ID: <20160108100711.783696cb@bahia.local> In-Reply-To: <568EC1E4.3050403@redhat.com> References: <20160107110747.10897.41118.stgit@bahia.huguette.org> <20160107113208.10897.13792.stgit@bahia.huguette.org> <568EC1E4.3050403@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/6] Revert "vhost-net: tell tap backend about the vnet endianness" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" On Thu, 7 Jan 2016 20:52:04 +0100 Laurent Vivier wrote: > > > On 07/01/2016 12:32, Greg Kurz wrote: > > This reverts commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991. > > > > Cross-endian is now configured by the core virtio-net code. We simply > > fall back on full emulation if the net backend cannot support the > > requested endianness for vnet headers. > > > > Signed-off-by: Greg Kurz > > --- > > hw/net/vhost_net.c | 33 +-------------------------------- > > hw/net/virtio-net.c | 7 +++++++ > > 2 files changed, 8 insertions(+), 32 deletions(-) > > > > diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c > > index 318c3e6ad213..0c7362b7a772 100644 > > --- a/hw/net/vhost_net.c > > +++ b/hw/net/vhost_net.c > > @@ -38,7 +38,6 @@ > > #include "standard-headers/linux/virtio_ring.h" > > #include "hw/virtio/vhost.h" > > #include "hw/virtio/virtio-bus.h" > > -#include "hw/virtio/virtio-access.h" > > > > struct vhost_net { > > struct vhost_dev dev; > > @@ -199,27 +198,6 @@ static void vhost_net_set_vq_index(struct vhost_net *net, int vq_index) > > net->dev.vq_index = vq_index; > > } > > > > -static int vhost_net_set_vnet_endian(VirtIODevice *dev, NetClientState *peer, > > - bool set) > > -{ > > - int r = 0; > > - > > - if (virtio_vdev_has_feature(dev, VIRTIO_F_VERSION_1) || > > - (virtio_legacy_is_cross_endian(dev) && !virtio_is_big_endian(dev))) { > > - r = qemu_set_vnet_le(peer, set); > > - if (r) { > > - error_report("backend does not support LE vnet headers"); > > - } > > - } else if (virtio_legacy_is_cross_endian(dev)) { > > - r = qemu_set_vnet_be(peer, set); > > - if (r) { > > - error_report("backend does not support BE vnet headers"); > > - } > > - } > > - > > - return r; > > -} > > - > > static int vhost_net_start_one(struct vhost_net *net, > > VirtIODevice *dev) > > { > > @@ -308,11 +286,6 @@ int vhost_net_start(VirtIODevice *dev, NetClientState *ncs, > > goto err; > > } > > > > - r = vhost_net_set_vnet_endian(dev, ncs[0].peer, true); > > - if (r < 0) { > > - goto err; > > - } > > - > > for (i = 0; i < total_queues; i++) { > > vhost_net_set_vq_index(get_vhost_net(ncs[i].peer), i * 2); > > } > > @@ -320,7 +293,7 @@ int vhost_net_start(VirtIODevice *dev, NetClientState *ncs, > > r = k->set_guest_notifiers(qbus->parent, total_queues * 2, true); > > if (r < 0) { > > error_report("Error binding guest notifier: %d", -r); > > - goto err_endian; > > + goto err; > > } > > > > for (i = 0; i < total_queues; i++) { > > @@ -342,8 +315,6 @@ err_start: > > fprintf(stderr, "vhost guest notifier cleanup failed: %d\n", e); > > fflush(stderr); > > } > > -err_endian: > > - vhost_net_set_vnet_endian(dev, ncs[0].peer, false); > > err: > > return r; > > } > > @@ -366,8 +337,6 @@ void vhost_net_stop(VirtIODevice *dev, NetClientState *ncs, > > fflush(stderr); > > } > > assert(r >= 0); > > - > > - assert(vhost_net_set_vnet_endian(dev, ncs[0].peer, false) >= 0); > > } > > > > void vhost_net_cleanup(struct vhost_net *net) > > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > > index d4cc94ea5e55..5a0ab6ad5bb5 100644 > > --- a/hw/net/virtio-net.c > > +++ b/hw/net/virtio-net.c > > @@ -128,6 +128,13 @@ static void virtio_net_vhost_status(VirtIONet *n, uint8_t status) > > if (!n->vhost_started) { > > int r, i; > > > > + if (n->needs_vnet_hdr_swap) { > > + error_report("backend does not support %s vnet headers." > > + "falling back on userspace virtio", > > + virtio_is_big_endian(vdev) ? "BE" : "LE"); > > + return; > > + } > > + > > This is not part of the revert, perhaps this can go in PATCH 1/6 ? > In virtio_net_vnet_status() ? > Makes sense. I'll fix that. > > /* Any packets outstanding? Purge them to avoid touching rings > > * when vhost is running. > > */ > > > > >