Re: [Qemu-devel] [PATCH v1 00/15] data-driven device registers

["Edgar E. Iglesias" <edgar.iglesias@gmail.com>]

On Fri, Jan 08, 2016 at 10:40:28AM +0000, Peter Maydell wrote:
> On 8 January 2016 at 00:39, Alistair Francis
> <alistair.francis@xilinx.com> wrote:
> > On Wed, Dec 16, 2015 at 8:33 AM, Alistair Francis
> > <alistair.francis@xilinx.com> wrote:
> >> On Tue, Dec 15, 2015 at 1:56 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
> >>> On 15 December 2015 at 20:52, Peter Crosthwaite
> >>> <crosthwaitepeter@gmail.com> wrote:
> >>>> It needs to exist before it can be used so there is a bit of a chicken
> >>>> and egg problem there.
> >
> > No one seems to be jumping at reviewing this. Can we just send a pull request?
> 
> I don't necessarily require review [*]. I would like *somebody* other
> than you Xilinx folk to say "yes, I think I would use this for
> modelling devices". Otherwise all we have is "weird thing used
> only in two or three Xilinx devices and nowhere else", which I'm
> a bit reluctant to let into the tree. We already have a pretty
> wide divergence in how devices look just based on the various
> transitions from older to newer qdev/QOM/etc that are not complete.
> 
> [*] by which I mean, I will review this series if you can find
> somebody else who's going to say they'd use it.
>

Hi,

I have two general comments to the series.

1. I think we need to do something to allow mem-attributes to be passed to the reg-access callbacks and possibly also to add a way to filter on attrs in the data structure.

2. We had trouble in the Xilinx tree with the number of memory regions created when using the style were each reg becomes an MR. I think that style should either be disallowed or we need to fix the low limit (IIRC it was at around 1K MRs/Regs).

I'm part of the Xilinx team so I this outside of Peters review request but anyawy....

Cheers,
Edgar