From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41656)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1aHTxU-0004OU-49
	for qemu-devel@nongnu.org; Fri, 08 Jan 2016 05:07:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1aHTxP-0008M3-Sm
	for qemu-devel@nongnu.org; Fri, 08 Jan 2016 05:07:48 -0500
Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:41351)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1aHTxP-0008Lw-JC
	for qemu-devel@nongnu.org; Fri, 08 Jan 2016 05:07:43 -0500
Received: from localhost
	by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <cornelia.huck@de.ibm.com>;
	Fri, 8 Jan 2016 10:07:42 -0000
Received: from b06cxnps4075.portsmouth.uk.ibm.com
	(d06relay12.portsmouth.uk.ibm.com [9.149.109.197])
	by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 706392190046
	for <qemu-devel@nongnu.org>; Fri,  8 Jan 2016 10:07:30 +0000 (GMT)
Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com
	[9.149.37.229])
	by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id u08A7eeF4325828
	for <qemu-devel@nongnu.org>; Fri, 8 Jan 2016 10:07:40 GMT
Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id u08A7ePc011108
	for <qemu-devel@nongnu.org>; Fri, 8 Jan 2016 03:07:40 -0700
Date: Fri, 8 Jan 2016 11:07:38 +0100
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Message-ID: <20160108110738.7db971fe.cornelia.huck@de.ibm.com>
In-Reply-To: <20160108102140.0398ed37@bahia.local>
References: <20160107110747.10897.41118.stgit@bahia.huguette.org>
	<20160107113226.10897.23886.stgit@bahia.huguette.org>
	<568EC57E.1010002@redhat.com> <20160108102140.0398ed37@bahia.local>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/6] vhost: move virtio 1.0 check to
 cross-endian helper
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org, "Michael S.
	Tsirkin" <mst@redhat.com>

On Fri, 8 Jan 2016 10:21:40 +0100
Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:

> On Thu, 7 Jan 2016 21:07:26 +0100
> Laurent Vivier <lvivier@redhat.com> wrote:

> > IMHO, I think 4/6 and 5/6 can be merged as there is no change in the
> > behavior and they are only consolidating code.
> > 
> 
> Maybe but I'm not sure it is really needed to help acceptance.
> FWIW Cornelia already reviewed both patches.

I'd keep the two patches separate, as each is easier to understand on
its own IMO.