From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHTxU-0004OU-49 for qemu-devel@nongnu.org; Fri, 08 Jan 2016 05:07:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHTxP-0008M3-Sm for qemu-devel@nongnu.org; Fri, 08 Jan 2016 05:07:48 -0500 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:41351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHTxP-0008Lw-JC for qemu-devel@nongnu.org; Fri, 08 Jan 2016 05:07:43 -0500 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 8 Jan 2016 10:07:42 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 706392190046 for ; Fri, 8 Jan 2016 10:07:30 +0000 (GMT) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u08A7eeF4325828 for ; Fri, 8 Jan 2016 10:07:40 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u08A7ePc011108 for ; Fri, 8 Jan 2016 03:07:40 -0700 Date: Fri, 8 Jan 2016 11:07:38 +0100 From: Cornelia Huck Message-ID: <20160108110738.7db971fe.cornelia.huck@de.ibm.com> In-Reply-To: <20160108102140.0398ed37@bahia.local> References: <20160107110747.10897.41118.stgit@bahia.huguette.org> <20160107113226.10897.23886.stgit@bahia.huguette.org> <568EC57E.1010002@redhat.com> <20160108102140.0398ed37@bahia.local> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/6] vhost: move virtio 1.0 check to cross-endian helper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: Laurent Vivier , qemu-devel@nongnu.org, "Michael S. Tsirkin" On Fri, 8 Jan 2016 10:21:40 +0100 Greg Kurz wrote: > On Thu, 7 Jan 2016 21:07:26 +0100 > Laurent Vivier wrote: > > IMHO, I think 4/6 and 5/6 can be merged as there is no change in the > > behavior and they are only consolidating code. > > > > Maybe but I'm not sure it is really needed to help acceptance. > FWIW Cornelia already reviewed both patches. I'd keep the two patches separate, as each is easier to understand on its own IMO.