From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aI0uP-0003an-0I for qemu-devel@nongnu.org; Sat, 09 Jan 2016 16:18:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aI0uL-0001KL-Lp for qemu-devel@nongnu.org; Sat, 09 Jan 2016 16:18:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37930) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aI0uL-0001K2-Gc for qemu-devel@nongnu.org; Sat, 09 Jan 2016 16:18:45 -0500 Date: Sat, 9 Jan 2016 23:18:41 +0200 From: "Michael S. Tsirkin" Message-ID: <20160109231820-mutt-send-email-mst@redhat.com> References: <1452274455-83334-1-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1452274455-83334-1-git-send-email-imammedo@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] pc: acpi: fix build fail on w32 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org On Fri, Jan 08, 2016 at 06:34:15PM +0100, Igor Mammedov wrote: > build fail with warnings on w32 compiler: >=20 > hw/acpi/memory_hotplug_acpi_table.c: > In function =E2=80=98build_memory_hotplug_aml=E2=80=99: > hw/acpi/memory_hotplug_acpi_table.c:148: > warning: integer constant is too large for =E2=80=98long=E2=80=99 type > hw/acpi/memory_hotplug_acpi_table.c:149: > warning: integer constant is too large for =E2=80=98long=E2=80=99 type >=20 > fix it by expilictly saying that int const is 64bit number >=20 > Signed-off-by: Igor Mammedov thanks! Make it a fixup! patch next time pls. > --- > hw/acpi/memory_hotplug_acpi_table.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/acpi/memory_hotplug_acpi_table.c b/hw/acpi/memory_hotpl= ug_acpi_table.c > index 20728ac..080d9ad 100644 > --- a/hw/acpi/memory_hotplug_acpi_table.c > +++ b/hw/acpi/memory_hotplug_acpi_table.c > @@ -145,8 +145,8 @@ void build_memory_hotplug_aml(Aml *ctx, uint32_t nr= _mem, > aml_append(crs_tmpl, > aml_qword_memory(AML_POS_DECODE, AML_MIN_FIXED, AML_MA= X_FIXED, > AML_CACHEABLE, AML_READ_WRITE, > - 0, 0x0, 0xFFFFFFFFFFFFFFFE, 0, > - 0xFFFFFFFFFFFFFFFF)); > + 0, 0x0, 0xFFFFFFFFFFFFFFFEULL, 0, > + 0xFFFFFFFFFFFFFFFFULL)); > aml_append(method, aml_name_decl("MR64", crs_tmpl)); > aml_append(method, > aml_create_dword_field(mr64, aml_int(14), "MINL")); > --=20 > 1.8.3.1