From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44324) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIeH4-0004El-Rv for qemu-devel@nongnu.org; Mon, 11 Jan 2016 10:20:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aIeH3-0002Mz-Vd for qemu-devel@nongnu.org; Mon, 11 Jan 2016 10:20:50 -0500 Date: Mon, 11 Jan 2016 16:20:43 +0100 From: Kevin Wolf Message-ID: <20160111152043.GD9454@noname.redhat.com> References: <1450802786-20893-1-git-send-email-kwolf@redhat.com> <1450802786-20893-2-git-send-email-kwolf@redhat.com> <5679B08B.7090608@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="neYutvxvOLaeuPCA" Content-Disposition: inline In-Reply-To: <5679B08B.7090608@redhat.com> Subject: Re: [Qemu-devel] [PATCH 01/10] qcow2: Write feature table only for v3 images List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com --neYutvxvOLaeuPCA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 22.12.2015 um 21:20 hat Eric Blake geschrieben: > On 12/22/2015 09:46 AM, Kevin Wolf wrote: > > Version 2 images don't have feature bits, so writing a feature table to > > those images is kind of pointless. >=20 > Fortunately, it is also harmless; even the v2 spec allowed for unknown > extension headers. With 512 byte clusters it could use up important space that you wanted to use for the backing file path! Okay, okay, maybe not that critical... ;-) > >=20 > > Signed-off-by: Kevin Wolf > > --- > > block/qcow2.c | 48 ++++++++++++++++++++++++--------------= -------- > > tests/qemu-iotests/031.out | 12 +----------- > > tests/qemu-iotests/061.out | 15 --------------- > > 3 files changed, 26 insertions(+), 49 deletions(-) > >=20 >=20 > Reviewed-by: Eric Blake >=20 > Did you test that amend'ing an image from v2 to v3 adds the table, and > downgrading from v3 to v2 drops the table? I'm not sure if I tested it manually, but I'm updating the results of test case 061, which tests both upgrades and downgrades, so if your review was thorough enough, the answer is yes. Kevin --neYutvxvOLaeuPCA Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJWk8hKAAoJEH8JsnLIjy/WQ/8QAMH5U3vABaSTMtN6GpbW1xhx Eb6Sw4OD/bFCsUTv+vvHIZ6MXNqKRzU0B/cu3xbuBal7AbXexyra4Elvl0vhMoEI gWLpz538Fe4hO4y/R3GfYkOBnmHRKYjEDwaHlX4GqJmvgGolG9C5RsKQTuVIDrfb k7wCSR3YzlitNjIo5a8PlsdLRXsoOfmkumaBSdt9jjqZJvBh+J7ETkWesZmgZF/w ONLn+97Gl68r/nkOHE1Si2c82IGUyQ/Q9pk9dAIjcsZcF4fNbiyvpMKQi76Th+vu qZFlNvENjl3BQRTQhj1tDZdFzlcS72tW9ThJFcuGnKaHrxHPe2cYqmaJbWsWxnfc mSune7HzV2geAByCpCHdA5RFWjjHoDfJs1lBTviQPKwBwlGIM3w0BR9XLwaDcUpi HiiyXsxFf0l8YnZYz5rmmYCz/h+Q+fe/QsBC5vbUm2r8t/bOlIdu8yP0UfD4YL0K /Zdct8gwNaeaTRW+tU/U9f6zdyt7OzDxxIc3SzPURGPb3KaT9MhMjgerYiixAIOp 4ZCzWHuU9jA8dSyhM1ldtskqCogi0hstoamaSmWdJSRmzbEZOBYwcBtpeold4jpM 25sAlwES+rIg1Kj1suubUhrCn4N0J2B3kfU94KG30Gu9NfpCpvOGjs7pIY60xG/7 e5rhWMrSvBUlAMtlLDuV =w3wa -----END PGP SIGNATURE----- --neYutvxvOLaeuPCA--