From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46588) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIeOE-0000nV-QM for qemu-devel@nongnu.org; Mon, 11 Jan 2016 10:28:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aIeOD-0004Yj-LT for qemu-devel@nongnu.org; Mon, 11 Jan 2016 10:28:14 -0500 Date: Mon, 11 Jan 2016 15:28:04 +0000 From: "Daniel P. Berrange" Message-ID: <20160111152804.GG20117@redhat.com> References: <1450709966-2998-1-git-send-email-berrange@redhat.com> <87a8ocup4j.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87a8ocup4j.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH v2 0/3] Use QCryptoSecret for block device passwords Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Kevin Wolf , Josh Durgin , qemu-block@nongnu.org, Jeff Cody , qemu-devel@nongnu.org, Ronnie Sahlberg , Paolo Bonzini On Mon, Jan 11, 2016 at 04:12:12PM +0100, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > The RBD, Curl and iSCSI block device drivers all need the ability > > to accept a password to authenticate with the remote network storage > > server. Currently RBD and iSCSI both just take the password in clear > > text as part of the block parameters which is insecure (passwords are > > visible in the process listing), while Curl doesn't support auth at > > all. > > > > This series updates all three drivers so that they use the recently > > merged QCryptoSecret API for getting passwords. Each driver gains > > a 'passwordid' property that can be set to provide the ID of a > > QCryptoSecret object instance, which in turn provides the actual > > password data. > > I'd find password-id easier to read than passwordid. Sure, works for me - I'm ambivalent either way, so will update it. > > These patches were previously sent as part of a larger series: > > > > https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg04365.html > > > > The QCryptoSecret object support was already merged, and the additions > > to qemu-img/qemu-io/qemu-nbd I'll submit separately since there is no > > strict dependancy between those additions and these patches. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|