From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIdl2-000629-Fp for qemu-devel@nongnu.org; Mon, 11 Jan 2016 09:47:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aIdkz-0001ZD-8y for qemu-devel@nongnu.org; Mon, 11 Jan 2016 09:47:44 -0500 Date: Mon, 11 Jan 2016 15:47:24 +0100 From: Igor Mammedov Message-ID: <20160111154724.11f33883@nial.brq.redhat.com> In-Reply-To: <20160111142624.GA12626@rkaganb.sw.ru> References: <1451506316-31975-1-git-send-email-rkagan@virtuozzo.com> <20160111145115.215a5869@nial.brq.redhat.com> <20160111142624.GA12626@rkaganb.sw.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 0/6] i386: expose floppy-related objects in SSDT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Roman Kagan Cc: Michael Roth , qemu-devel@nongnu.org, qemu-stable@nongnu.org On Mon, 11 Jan 2016 17:26:26 +0300 Roman Kagan wrote: > On Mon, Jan 11, 2016 at 02:51:15PM +0100, Igor Mammedov wrote: > > On Wed, 30 Dec 2015 23:11:50 +0300 > > Roman Kagan wrote: > > > > > Windows on UEFI systems is only capable of detecting the presence and > > > the type of floppy drives via corresponding ACPI objects. > > > > > > Those objects are added in patch 5; the preceding ones pave the way to > > > it, by making the necessary data public and by moving the whole > > > floppy drive controller description into runtime-generated SSDT. > > > > > > Note that the series conflicts with Igor's patchset for dynamic DSDT, in > > > particular, with "[PATCH v2 27/51] pc: acpi: move FDC0 device from DSDT > > > to SSDT"; I haven't managed to avoid that while trying to meet > > > maintainer's comments. > > > > > > Hello Roman, > > > > I've rebased/rewrote this series on top of current PCI tree. > > Could you tell me if I should keep your Author/SoB on following > > patches or change/drop it and if it's the case please specify what > > should be changed: > > > > i386/acpi: make floppy controller object dynamic > > https://github.com/imammedo/qemu/commit/f0a3a4761f8f9698d0f0117d47e2353505de37bf > > i386: populate floppy drive information in DSDT > > https://github.com/imammedo/qemu/commit/97578d32e0a0b1cea0b6229f5ef51f8e104b7fdb > > Both patches look good to me (I just noticed an excessive "to" in the > log message of the second one, in "QEMU doesn't _to_ provide those > objects in its ACPI tables", you may want to delete it before > propagating the patch upstream). Just to confirm, so you are agree with me keeping you as Author on above patches and your SoB on them as well? > Now what are the plans re. stable branches? I think the problem of the > floppy being unavaliable in Windows on UEFI/OVMF justifies porting it > there (we are interested, in particular, in stable-2.3), but I'm now > confused as to what state to use as the base. > > (As a matter of fact I'd been hoping that my patches made it in before > your dynamic DSDT rework so the backport would be trivial cherry-pick; > as this is no longer the case I'd appreciate your (or anybody else's) > advice on how to move on with stable.) Stable could use reviewed v5 if Michael agrees to take fix. > > Thanks, > Roman.