From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIgP6-0006Dh-DD for qemu-devel@nongnu.org; Mon, 11 Jan 2016 12:37:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aIgP2-0006vj-E0 for qemu-devel@nongnu.org; Mon, 11 Jan 2016 12:37:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47890) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIgP2-0006vX-8q for qemu-devel@nongnu.org; Mon, 11 Jan 2016 12:37:12 -0500 Date: Mon, 11 Jan 2016 18:37:09 +0100 From: Kevin Wolf Message-ID: <20160111173709.GM9454@noname.redhat.com> References: <567A4EB0.1040807@parallels.com> <1450856816-9816-1-git-send-email-den@openvz.org> <1450856816-9816-5-git-send-email-den@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450856816-9816-5-git-send-email-den@openvz.org> Subject: Re: [Qemu-devel] [PATCH 4/5] qcow2: implemented bdrv_is_opened_unclean List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Fam Zheng , Olga Krishtal , qemu-devel@nongnu.org, Max Reitz Am 23.12.2015 um 08:46 hat Denis V. Lunev geschrieben: > From: Olga Krishtal > > While opening image we save dirty state in header_unclean. > If the image was closed incorrectly we can retrieve this fact > using bdrv_is_opened_unclean callback. > > This is necessary in case when we want to call brdv_check to > repair dirty image. > > Signed-off-by: Olga Krishtal > Signed-off-by: Denis V. Lunev > CC: Kevin Wolf > CC: Max Reitz > CC: Eric Blake > CC: Fam Zheng What does this fix? qcow2 isn't supposed to require a repair after an unclean shutdown. The only exception is with lazy-refcounts=on, which already sets a dirty flag in the header and triggers the repair in qcow2_open(). Kevin