From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIqc4-0001MM-DY for qemu-devel@nongnu.org; Mon, 11 Jan 2016 23:31:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aIqc3-0001la-7r for qemu-devel@nongnu.org; Mon, 11 Jan 2016 23:31:20 -0500 Date: Tue, 12 Jan 2016 15:31:08 +1100 From: David Gibson Message-ID: <20160112043108.GR22925@voom.redhat.com> References: <1452093205-30167-1-git-send-email-eric.auger@linaro.org> <1452093205-30167-8-git-send-email-eric.auger@linaro.org> <20160111024554.GD22925@voom.redhat.com> <56938FA3.5070600@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ABd7dauUP597Mpr3" Content-Disposition: inline In-Reply-To: <56938FA3.5070600@linaro.org> Subject: Re: [Qemu-devel] [PATCH v2 7/7] hw/arm/sysbus-fdt: remove qemu_fdt_setprop returned value check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Auger Cc: b.reynal@virtualopensystems.com, peter.maydell@linaro.org, thuth@redhat.com, eric.auger@st.com, patches@linaro.org, crosthwaitepeter@gmail.com, qemu-devel@nongnu.org, alex.williamson@redhat.com, qemu-arm@nongnu.org, suravee.suthikulpanit@amd.com, pbonzini@redhat.com, thomas.lendacky@amd.com, alex.bennee@linaro.org, christoffer.dall@linaro.org --ABd7dauUP597Mpr3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 11, 2016 at 12:18:59PM +0100, Eric Auger wrote: > Hi David, > On 01/11/2016 03:45 AM, David Gibson wrote: > > On Wed, Jan 06, 2016 at 03:13:25PM +0000, Eric Auger wrote: > >> qemu_fdt_setprop self-exists in case of error hence no need to check > >> the returned value. > >> > >> Signed-off-by: Eric Auger > >=20 > > This change is fine, but in general I'm disinclined to invest too much > > in the qemu interfaces for manipulating flattened trees. > >=20 > > I think our device tree manipulation in qemu is now complicated enough > > that we should move towards using an unflattened (i.e. pointer based) > > DT representation inside qemu, which is generally more suitable for > > complex manipulation. > OK. Is there any user-space library available for un-flattened tree > manipulation? I only found references to kernel unflattened tree > manipulations (drivers/of/fdt.c, include/linux/of.h) and dtc flattree.c. Not that I'm aware of. I've sometimes thought of making one as another companion project to dtc. Or it would be reasonably straightforward to build a qemu specific one using qemu's existing list routines. > Besides the indicated direction do I understand correctly that you do > not reject the series? Yes, that's correct. I think working with unflattened trees is something we should head towards somewhere in the future, but that's certainly not a reason to hold up real improvements based on the existing flattened tree code. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --ABd7dauUP597Mpr3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWlIGLAAoJEGw4ysog2bOSHWEP/jyLnEyVV3LzeSRlSZLb9F7V ePGRGTS+8bSAt1efjDiN0gc6Bc7dEvG6tWHVF6C9pfy0x47POXCr8EPsnj2Te8zE KTOO8QXTzUYLS5HeCw+tkJeaiyjolW9OvhuzPglH5OI7jVXXRhsQ8krRGMt+STb5 S6GoqjSveqxkQqGPU87GRpgCg0DMExiQfmlrb0itDQRvx07f92kRdO8+iW0Og3Nf //Ic9Y7O5VAIQFZwdE/oXAXY0+UjVwfMhask5pTiZepxiHQdqs77HBCitXwyDD4K xTfXLqA0KGDudrpnQXy4ydtIfKUpc7J08f7qjJkwpwGHfUnuPapROFVm6rbKJTxH IAviu88Xmw1Z9VpGJm3sYhgt9tbXnrgyBDmXPmstYWfYDS2UToeM7ckTms29+zLn bLxW8cLQQKMPur8+uoxvVtzC5Erj2rhEamjx8RyV7Ab956/6gGJid/gkMqCtUq58 L19NORbOYeFwPFaNLj4a9sGZa8toCUmYx+TOSEMR0V5I82haNcQpVnTm85Ea9JXq Tkeve7j3LAaxfaR/jbpRZv85fBmmpsUUN3RDEEhF9efdaqqcBb2yVc9IkHBXEhue YDDv9J8cIk7qTvUBYnaKmiFsKwBJ1hbDrg+ralP45+SWVYSHYHH44lzt5i/YkTjw nmZQJK6bABaTj8kvtGpY =Llqg -----END PGP SIGNATURE----- --ABd7dauUP597Mpr3--